chore(typechecking): typecheck /lib #1138
Conversation
pdesoyres-cc
requested review from
hsablonniere,
Galimede,
florian-sanders-cc,
roberttran-cc and
HeleneAmouzou
pdesoyres-cc
added
the
maintenance
pdesoyres-cc
force-pushed
the
more-typechecking
branch
from
0ab8fc6 to
ca14672
Compare
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/more-typechecking/index.html. This preview will be deleted once this PR is closed. |
There was a problem hiding this comment.
Gg @pdesoyres-cc this is great!
I've only added a few nitpicks & some suggestions to avoid a few @ts-ignore but apart from that it's all good.
I must admit I did not have enough time to review the smart component part thoroughly so I'll get back to that when I come back if it's not already merged.
pdesoyres-cc
force-pushed
the
more-typechecking
branch
2 times, most recently
from
a60b0dd to
e23f12f
Compare
There was a problem hiding this comment.
Well done 👏 I did not review the smart component relative files and I focused on the other files. I have no comments to make, but I have discovered unknown ways of typechecking, thanks ! I will come back later when the other will have review the PR, considering the subject I think it might be interesting for me to read the reviews from the team.
There was a problem hiding this comment.
Impressive work @pdesoyres-cc, well done!!!
There are still TS issues when importing modules from clever client.
It seems like there will be improvements on this soon ™️ CleverCloud/clever-client.js#57 (comment)
Really nice that you added function descriptions in the JSDoc!!!
This prevents us from including all /lib directory in typecheck:ci task.
Can we add the files that don't have this problem, one by one?
We could use This allows us to typecheck the rest of the file and when the client exposes types, the |
pdesoyres-cc
force-pushed
the
more-typechecking
branch
from
e23f12f to
c491469
Compare
pdesoyres-cc
force-pushed
the
more-typechecking
branch
from
c491469 to
6917821
Compare
|
🔎 The preview has been automatically deleted. |
what is this PR
This PR adds typechecking on almost all files in
/lib.There are still TS issues when importing modules from clever client.
This prevents us from including all
/libdirectory intypecheck:citask.todo