Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP implementation for patch level world cover embeddings #231

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

lillythomas
Copy link
Contributor

@lillythomas lillythomas force-pushed the patch_level_worldcover branch from c962128 to 081e8de Compare April 25, 2024 06:11
@lillythomas lillythomas force-pushed the patch_level_worldcover branch from 9e5cdc5 to d9e8eb2 Compare April 25, 2024 06:18
@lauracchen
Copy link
Member

Hi @lillythomas ! Thanks so much for this. Would you also be able to update the worldcover script to include the option to generate embeddings with all bands included (not just partial inputs)? The app team is wondering if generating with only a couple bands is having an impact on performance.

cc @antymoro @lukaszknasiecki

@lillythomas
Copy link
Contributor Author

Hi @lauracchen sure thing!

@lillythomas lillythomas force-pushed the patch_level_worldcover branch from 31625a6 to 7bb7909 Compare April 26, 2024 16:36
@lillythomas
Copy link
Contributor Author

Actually @lauracchen it appears the Worldcover composite we are using is just RGB-Nir (https://esa-worldcover.org/en/data-access). There is a SWIR composite provided as well, which we can stack on the RGB-Nir, but this still misses out on 4/10 Sentinel-2 inputs. We can similarly stack the Sentinel-1 composite as well.

@lillythomas
Copy link
Contributor Author

Patch-level sim search with the currently-in-place RGB-Nir worldcover model is working, albeit the results are still a bit random:

Example 1:
Screenshot 2024-04-26 at 11 30 11 AM

Example 2:
Screenshot 2024-04-26 at 11 10 52 AM

Working on the adjustments per #231 (comment)

@lillythomas lillythomas force-pushed the patch_level_worldcover branch from 53b666c to a7dd3c8 Compare May 1, 2024 19:13
@lillythomas lillythomas force-pushed the patch_level_worldcover branch from 7bebe6d to be3cc33 Compare May 1, 2024 21:53
@lillythomas
Copy link
Contributor Author

@antymoro I've implemented the concatenation of the RGB-Nir composite with the SWIR and SAR composites (see the new script run_msi_sar.py). Feel free to try it on your end.

@lillythomas lillythomas force-pushed the patch_level_worldcover branch from 49bf34a to f17ae75 Compare May 1, 2024 22:58
@lillythomas lillythomas force-pushed the patch_level_worldcover branch from 47c9dca to 48ef01a Compare May 22, 2024 16:52
@lillythomas lillythomas requested a review from yellowcap May 22, 2024 17:43
Copy link
Member

@yellowcap yellowcap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are updating a lot of the examples we have to run with v1. So I think this would make sense as well to be updated to v1. But not sure if it's worth the additional effort now that we have seen the limitations of patch level embeddings, and with the flexibility in terms of image size for v1, where smaller embeddings can be generated without relying on patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants