-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP implementation for patch level world cover embeddings #231
base: main
Are you sure you want to change the base?
Conversation
c962128
to
081e8de
Compare
9e5cdc5
to
d9e8eb2
Compare
Hi @lillythomas ! Thanks so much for this. Would you also be able to update the worldcover script to include the option to generate embeddings with all bands included (not just partial inputs)? The app team is wondering if generating with only a couple bands is having an impact on performance. |
Hi @lauracchen sure thing! |
31625a6
to
7bb7909
Compare
Actually @lauracchen it appears the Worldcover composite we are using is just RGB-Nir (https://esa-worldcover.org/en/data-access). There is a SWIR composite provided as well, which we can stack on the RGB-Nir, but this still misses out on 4/10 Sentinel-2 inputs. We can similarly stack the Sentinel-1 composite as well. |
Patch-level sim search with the currently-in-place RGB-Nir worldcover model is working, albeit the results are still a bit random: Working on the adjustments per #231 (comment) |
53b666c
to
a7dd3c8
Compare
7bebe6d
to
be3cc33
Compare
@antymoro I've implemented the concatenation of the RGB-Nir composite with the SWIR and SAR composites (see the new script |
49bf34a
to
f17ae75
Compare
for more information, see https://pre-commit.ci
47c9dca
to
48ef01a
Compare
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are updating a lot of the examples we have to run with v1. So I think this would make sense as well to be updated to v1. But not sure if it's worth the additional effort now that we have seen the limitations of patch level embeddings, and with the flexibility in terms of image size for v1, where smaller embeddings can be generated without relying on patches.
Relates to https://github.com/orgs/Clay-foundation/discussions/291