Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map): Add basic map in homepage #7

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Zen-cronic
Copy link
Contributor

@Zen-cronic Zen-cronic commented Nov 16, 2024

Resolves #3

  • Map created using leaflet and react-leaflet
  • default configs based on v1 repo's configs

Current view:

tracket-basic-map

@Zen-cronic
Copy link
Contributor Author

With clusters and tooltips:

tracket-basic-map-clusters

{locations.map((l) => {
const position: LatLngTuple = [l.latitude, l.longitude];
const toolTipActive = l.active
? "Active Location"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<br></br>
{toolTipLabel}
</div>
</Tooltip>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a separate component of its own. To be refactored


createRoot(document.getElementById('root')!).render(
<StrictMode>
<div>Hello, World!</div>
<Map/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: move it inside a parent component after setting up routing

@Zen-cronic
Copy link
Contributor Author

updated look (similar to v1):

tracket-map-clusters-updated

TODO:

  • Make components out of custom clusters and tooltips
  • Include the device in Hamilton (id 782239) into initial load view
  • Set up e2e test with playwright to verify the number of clusters/markers before making further design changes (probably in an another PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a basic map page for the homepage
1 participant