Add basic USWDS theme #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgading
force-pushed
the
PGOV-414-custom-theme
branch
from
3511792 to
a79ab82
Compare
|
Removed the ticket number since I was able to hide the preview button via config in #41 |
added 3 commits
December 17, 2024 13:56
Remove material icons to shrink PR
dgading
force-pushed
the
PGOV-414-custom-theme
branch
from
a79ab82 to
d6b8197
Compare
vauxia
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
I would like to see this get in as soon as practical, mainly to avoid the need to update composer locks / etc.
Beyond that:
- The changes are confined to the Drupal theme folder, where it is easy to iterate -- or simply delete
- It improves the experience but uplifting the login page and making it more consistent with the site's front end
- Yet it does not make a radical change, because the rest of the admin site is still using Gin.
This is one of those two-way door decisions (one that can be reversed easily) that adds value without 'costing' a lot.
|
This also affects the Content Administration area -- when you click on the title of a post, it links to Drupal's version of the item. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new custom theme, fixes a couple of things I saw in preview mode and replaces the footer to match the decoupled site. I removed the material design icons that normally come with the USWDS base theme since it added about 2k more images that we probably wouldn't be using.