This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Update to beaker 1.11 to get samesite cookie support #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@woodt I'm guessing that this is still relevant and wanted. If you'd like, I can include this in the 2.9 upgrade. 2.9 does bump Not sure if you were waiting on something for this PR, but feel free to request reviews from me any time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beaker 1.11 supports setting the SameSite attribute for cookies. We use Beaker to manage the CKAN session cookie.
I did some testing with Beaker 1.11 on staging and haven't found any problems, but I have not yet run the integration tests.