adding cypress-audit and examples #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the issue that we are running the default electron browser? Does it work with that browser? |
|
@dmundra I took out the pa11y dependency since the docs for that plugin are sparse and it looks like lighthouse is what cypress-audit does best. I can create an issue to look into the pa11y plugin, but that all depends on if the maintainer is going to improve the docs or not. They might not have time to support it vs. supporting the lighthouse part. |
3 tasks
dmundra
previously approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Thanks @alexfinnarn. This looks great and agreed we can revisit pa11y later.
dmundra
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to get rid of this error while tests run: https://github.com/mfrachet/cypress-audit/blob/53776e9654da16d68b30cce8896b487b1a87aafa/packages/shared/index.js#L10
Should be able to do this by setting the
CYPRESS_REMOTE_DEBUGGING_PORT, but I'm not sure how yet.closes #23