-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/search filter by rank and generate syllables only for compoundwords #216
base: develop
Are you sure you want to change the base?
Feature/search filter by rank and generate syllables only for compoundwords #216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check minor comment
services/search/api.py
Outdated
try: | ||
rank_threshold = float(params.get("rank_threshold")) | ||
except ValueError: | ||
raise ParseError("'rank_threshold' need to be of type float.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo need
--> needs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Codecov ReportBase: 65.41% // Head: 65.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #216 +/- ##
===========================================
- Coverage 65.41% 65.40% -0.02%
===========================================
Files 206 206
Lines 11903 11914 +11
Branches 1539 1541 +2
===========================================
+ Hits 7786 7792 +6
- Misses 3774 3778 +4
- Partials 343 344 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Filter by rank and generate syllables for only for compounwords.
Breakdown:
Files changes