Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/search filter by rank and generate syllables only for compoundwords #216

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

juuso-j
Copy link

@juuso-j juuso-j commented Jan 17, 2023

Filter by rank and generate syllables for only for compounwords.


Breakdown:

Files changes

  1. services/search/api.py
    • Filter by rank and add rank_threshold param
  2. services/search/constants.py
    • Remove LENGTH_OF_HYPHENATED_WORDS constant
  3. services/search/specification.swagger.yaml
    • Add info about rank_threshold_param
  4. services/search/utils.py
    • Hyphenate only compound words

@juuso-j juuso-j added the enhancement New feature or request label Jan 17, 2023
@juuso-j juuso-j requested review from mhieta and ezkat January 17, 2023 12:44
@juuso-j juuso-j self-assigned this Jan 17, 2023
Copy link
Collaborator

@mhieta mhieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check minor comment

try:
rank_threshold = float(params.get("rank_threshold"))
except ValueError:
raise ParseError("'rank_threshold' need to be of type float.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo need --> needs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 65.41% // Head: 65.40% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (6f5d9c6) compared to base (c4e7ec3).
Patch coverage: 62.50% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #216      +/-   ##
===========================================
- Coverage    65.41%   65.40%   -0.02%     
===========================================
  Files          206      206              
  Lines        11903    11914      +11     
  Branches      1539     1541       +2     
===========================================
+ Hits          7786     7792       +6     
- Misses        3774     3778       +4     
- Partials       343      344       +1     
Impacted Files Coverage Δ
services/search/api.py 67.32% <14.28%> (-1.23%) ⬇️
services/search/constants.py 100.00% <100.00%> (ø)
services/search/utils.py 67.70% <100.00%> (+1.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants