Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method Override feature (HPH-35) #279

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Method Override feature (HPH-35) #279

merged 6 commits into from
Nov 30, 2023

Conversation

suutari-ai
Copy link
Collaborator

Document and implement a new feature named Method Override.

Check details of the feature from the provided Markdown documentation file.

Add a document that describes the Method Override feature, which will be
implemented if the spec is approved.

A PDF version of the spec can be converted from the MD with pandoc.
Implement the method override feature as was documented in the previous
commit:

Make it possible to override the HTTP method of the API calls via a
query parameter named "method".  This allows using the API with some
limited clients which don't support all HTTP methods.

To enable this feature the real HTTP method has to be POST and (for now)
only supported methods are DELETE, PATCH and PUT.
The redoc-cli tool is deprecated and @redocly/cli is suggested as the
replacement so switch our generate-docs script to use the "openapi" from
@redocly/cli.  Also update all of the npm dependencies to their latest
versions.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ea809f) 94.48% compared to head (28bdc78) 94.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
+ Coverage   94.48%   94.52%   +0.03%     
==========================================
  Files         190      190              
  Lines        5843     5878      +35     
  Branches      398      403       +5     
==========================================
+ Hits         5521     5556      +35     
  Misses        250      250              
  Partials       72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suutari-ai suutari-ai merged commit d8a86c5 into master Nov 30, 2023
7 checks passed
@suutari-ai suutari-ai deleted the override-method branch November 30, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants