Dockerization: Add platform and change user uid #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify platform as "linux/amd64" for the app container in the docker-compose.yml, because that's what it's supposed to be and it won't even work on e.g. ARM based archs. (Some deps won't compile.) Change the appuser uid to 1000, since that is very often the same uid as the developer's uid on a Linux host, which could avoid some problems when the source tree is mounted as a volume to the container and still being modified from the host.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
=======================================
Coverage 94.70% 94.70%
=======================================
Files 187 187
Lines 5797 5797
Branches 389 389
=======================================
Hits 5490 5490
Misses 240 240
Partials 67 67 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify platform as "linux/amd64" for the app container in the docker-compose.yml, because that's what it's supposed to be and it won't even work on e.g. ARM based archs. (Some deps won't compile.)
Change the appuser uid to 1000, since that is very often the same uid as the developer's uid on a Linux host, which could avoid some problems when the source tree is mounted as a volume to the container and still being modified from the host.