Fixes #33: rewrite processor initialization, fix task queue and synchronization issue on Linux #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafa-be
commented
Oct 25, 2024
8 successful runs in a row 🎉 |
rafa-be
commented
Oct 25, 2024
rafa-be
force-pushed
the
fix_unit_test_bug
branch
from
a1898a7 to
de74cd9
Compare
sharpener6
previously approved these changes
Oct 29, 2024
|
Please bum up the version |
rafa-be
force-pushed
the
fix_unit_test_bug
branch
from
9733fd1 to
7ef1483
Compare
…nded task. Signed-off-by: rafa-be <[email protected]>
Signed-off-by: rafa-be <[email protected]>
…phase. Signed-off-by: rafa-be <[email protected]>
…y the active one. Signed-off-by: rafa-be <[email protected]>
Signed-off-by: rafa-be <[email protected]>
rafa-be
force-pushed
the
fix_unit_test_bug
branch
from
7ef1483 to
70e8aab
Compare
sharpener6
approved these changes
Oct 29, 2024
sharpener6
approved these changes
Oct 29, 2024
sharpener6
approved these changes
Oct 29, 2024
sharpener6
approved these changes
Oct 29, 2024
sharpener6
approved these changes
Oct 29, 2024
sharpener6
pushed a commit
to sharpener6/scaler
that referenced
this pull request
Dec 16, 2024
…ynchronization issue on Linux (Citi#40) * Fixes a bug in the async priority queue when trying to remove a suspended task. Signed-off-by: rafa-be <[email protected]> * Fixes a worker agent crash when trying to profile a zombie process. Signed-off-by: rafa-be <[email protected]> * Fixes Citi#33: processors can be suspended during the initialization phase. Signed-off-by: rafa-be <[email protected]> * The worker's heart-beat manager watches all worker processes, not only the active one. Signed-off-by: rafa-be <[email protected]> * Task priorities are now positive numbers. Signed-off-by: rafa-be <[email protected]> --------- Signed-off-by: rafa-be <[email protected]>
sharpener6
pushed a commit
to sharpener6/scaler
that referenced
this pull request
Dec 20, 2024
…ynchronization issue on Linux (Citi#40) * Fixes a bug in the async priority queue when trying to remove a suspended task. Signed-off-by: rafa-be <[email protected]> * Fixes a worker agent crash when trying to profile a zombie process. Signed-off-by: rafa-be <[email protected]> * Fixes Citi#33: processors can be suspended during the initialization phase. Signed-off-by: rafa-be <[email protected]> * The worker's heart-beat manager watches all worker processes, not only the active one. Signed-off-by: rafa-be <[email protected]> * Task priorities are now positive numbers. Signed-off-by: rafa-be <[email protected]> --------- Signed-off-by: rafa-be <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues that occurred on high nested task load (
TestNestedTask.test_multiple_recursive_task):AsyncPriorityQueuenow correctly removes tasks with a negative priority value;VanillaHeartbeatManagernow watches all processors (not only the active one), and better handle zombie and dead processes;