Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made the following fixes and improvements to
secure-firewall
Terraform IAC.template_file
as Hashicorp has deprecated it- I have implemented the templatefile() Functionapps.tf
andbastion.tf
as the hardcoded AMI ids makes it hard to deploy and test in different regions of AWS. I have implemented the data resource to lookup the Ubuntu AMI id .template_file
resource and implemented thetemplatefile() FunctionI have deployed and tested the
AWS_Workshop_Code
- it works as expected.