Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring to purely use Terraform #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ozooxo
Copy link

@ozooxo ozooxo commented May 2, 2019

The original demo repository have CloudFormation templates inside of Terraform files, which is quite confusing to understand and hard to modify.

I refactored it so everything is in Terraform now. My build passed: https://circleci.com/workflow-run/7d65d933-ae77-4e46-bc92-c6eec804aa90

Not sure if it is the direction the original author(s) want to approach, but just for sharing.

P.S I made some necessary changes to make it work with my own AWS account. Those changes need to be reverted: ozooxo/circleci-demo-aws-ecs-ecr@dd7e438...ozooxo:872f77ea09caebdf52148ab8f8d74c6ed5f677e4

@lokst
Copy link
Contributor

lokst commented May 8, 2019

@ozooxo Thank you for sharing this, I'll be reviewing it :)

@jdbohrman
Copy link

Is this going to be implemented? I would like to use this and personally think it's a much better way to go.

@lokst
Copy link
Contributor

lokst commented May 27, 2019

@jdbohrman Unfortunately it might be some time before I will be able to review this. Perhaps you could use the PR branch as a base though? The use of the CloudFormation template (via terraform) has been convenient for the purposes of this demo (it's easy to delete resources via CloudFormation stacks when necessary) so I would evaluate whether to merge this into the default branch or another branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants