Refactoring to purely use Terraform #6
+529
−531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original demo repository have CloudFormation templates inside of Terraform files, which is quite confusing to understand and hard to modify.
I refactored it so everything is in Terraform now. My build passed: https://circleci.com/workflow-run/7d65d933-ae77-4e46-bc92-c6eec804aa90
Not sure if it is the direction the original author(s) want to approach, but just for sharing.
P.S I made some necessary changes to make it work with my own AWS account. Those changes need to be reverted: ozooxo/circleci-demo-aws-ecs-ecr@dd7e438...ozooxo:872f77ea09caebdf52148ab8f8d74c6ed5f677e4