Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runner listener not destroyed on reload / exit #422

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Fix runner listener not destroyed on reload / exit #422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions src/runner-server-vscode/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ const { LanguageClient, TransportKind } = require('vscode-languageclient/node');
const path = require('path');
const cp = require('child_process');

var startRunner = null;
var finishPromise = null;

/**
* @param {vscode.ExtensionContext} context
*/
Expand Down Expand Up @@ -51,6 +54,7 @@ function activate(context) {
var address = null;
serverproc.stdout.on('data', async (data) => {
var sdata = data.asciiSlice();
console.log(sdata)
var i = sdata.indexOf("http://");
if(i !== -1) {
var end = sdata.indexOf('\n', i + 1);
Expand All @@ -75,8 +79,18 @@ function activate(context) {
if(address) {
args.push('--server', address)
}
context.subscriptions.push(vscode.window.createTerminal("runner.client", dotnetPath, args));

finishPromise = new Promise(onexit => {
startRunner = cp.spawn(dotnetPath, args, { encoding: 'utf-8', windowsHide: true, stdio: 'pipe', shell: false, env: { ...process.env, RUNNER_CLIENT_EXIT_AFTER_ENTER: "1" } });
startRunner.stdout.on('data', async (data) => {
var sdata = data.asciiSlice();
console.log(sdata)
});
startRunner.addListener('exit', code => {
console.log(code);
onexit();
});
})
const cspSource = panel.webview.cspSource;
// Get the content Uri
const style = panel.webview.asWebviewUri(
Expand Down Expand Up @@ -131,8 +145,12 @@ function activate(context) {
}

// this method is called when your extension is deactivated
function deactivate() {}

async function deactivate() {
if(finishPromise !== null) {
startRunner.stdin.write("\n");
await finishPromise;
}
}
module.exports = {
activate,
deactivate
Expand Down
Loading