Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh: update runner fork 2a fast forward #397

Merged
merged 388 commits into from
Sep 1, 2024

Conversation

ChristopherHX
Copy link
Owner

@ChristopherHX ChristopherHX commented Sep 1, 2024

The last merge has been with release 3.9.x.

This can certainly raise CI issues

Link- and others added 30 commits March 17, 2023 06:00
* Fix JIT configurations on Windows

* Update src/Runner.Listener/Runner.cs
* WIP

* WIP

* Add context

* Add 2494-runner-image-tags ADR draft

* Fix ADR title

* Add more information to option 2

* Add decision

* Fix status
* Parse runners and send publicKey

* wip

* Fix conflicts

* Cleanup

* Cleanup

* fix test

* fix test

* Add trace for broker message listener

* Feedback

* refactor

* remove dead code

* Remove old comment
* Guard against NullReference while creating HostContext

* Throw on IOUtil loading object if content is empty or object is null

* removed unused dependency

* Changed exceptions to ArgumentNullException and ArgumentException

* fixed my mistake on LoadObject

* fixed tests

* trigger workflows

* trigger workflows

* encode files using utf8
* Also send Steps update to Results service

* Refactor to separate results server from current job server

* If hit any error while uploading to Results, skip Results upload

* Add proxy authentication and buffer request for WinHttpHandler

* Remove unnecessary null guard

* Also send Results telemetry when step update fails

* IResultsServer is not disposable
…s#2196)

* which handles broken symlink & unit test added (actions#2150)

* Update src/Runner.Sdk/Util/WhichUtil.cs

Co-authored-by: Ferenc Hammerl <[email protected]>

* fix pr comments

* trace log added,  in case we find a symlink that is broken

* add check in case the target of the symlink is a relative path; added test that check symlink that targets a full path; added test that check symlink that targets a relative path;

* fix tests

* fix tests for linux

---------

Co-authored-by: Eli Entelis <[email protected]>
Co-authored-by: Eli Entelis <[email protected]>
Co-authored-by: Ferenc Hammerl <[email protected]>
* handle non success responses

* fix format

* nits

Co-authored-by: Tingluo Huang <[email protected]>

---------

Co-authored-by: Tingluo Huang <[email protected]>
* adding retry for flaky downloads

* adding comment

* Update src/Misc/externals.sh

Co-authored-by: Tingluo Huang <[email protected]>

---------

Co-authored-by: Tingluo Huang <[email protected]>
)

* adding retry-all-errors based on curl version >= 7.71.0

* adding logging

* fixing conditional logic
…actions#2547)

* Rename AcquireJobRequest::StreamID to AcquireJobRequest::JobMessageID to match corresponding server-side update.
* appeased the linter
* Added unit tests to prove AcquireJobRequest serialization/deserialization is as-expected.
* Distinguish unit test variations.
* Incorporated PR Feedback.
* Only upload to Results with new job message type

* No need to have separate websocketFeedServer

* Linting fix

* Update src/Runner.Common/JobServerQueue.cs

Co-authored-by: Tingluo Huang <[email protected]>

* add connection timeout

* Consolidate initializing webclient to result client

* Retry websocket delivery for console logs

* Linter fix

* Do not give up for good, reconnect again in 10 minutes

* Has to reset delivered

* Only first time retry 3 times to connect to websocket

---------

Co-authored-by: Tingluo Huang <[email protected]>
* Add orchestrationId to useragent for better correlation.

* .
* handle conflict errors from run service

* nit: formatting

* fix formatting
* send annotations to run-service

* skip message deletion

* actually don't skip deletion

* enum as numbers

* fix enum

* linting

* remove unncessary file

* feedback
…ctions#2311)

* [1742] Ensure multiple composite annoations are correctly written.

This implementation uses a collector pattern to allow embedded ExecutionContexts to stash Issue objects for later processing by a non-embedded ancestor ExecutionContext.

Also:
 - Provide explicit constructor implementations for ExecutionContext
 - Leverage explicit constructors to solidify immutability of several ExecutionContext class members.
 - Fixed erroneous call to ExecutionContext.Complete in CompositeActionHandler.cs
 - Use a consistent timestamp for FinishTime in ExecutionContext::Complete

* Ensure collected issues are processed only by a non-embedded ExecutionContext.
This was already implicit.  Now, just making it explicit.

* Provide a clear mechanism that allows callers to opt-in/opt-out of ExecutionContext::AddIssue's logging behavior.
* Addressed deserialization inconsistencies in TimelineRecord.cs
* Added TimelineRecord unit tests.
* Refined unit tests related to TimelineRecord::Variables case-insensitivity
* Add a unit test that verifies ExecutionContextLogOptions::LogMessageOverride has the desired effect.
* Responded to PR feedback.
* Don't allow embedded ExecutionContexts to add Issues to a TimelineRecord
…#2443)

* Add --no-default-labels option

Signed-off-by: Gabriel Adrian Samfira <[email protected]>

* Add tests

Signed-off-by: Gabriel Adrian Samfira <[email protected]>

* .

---------

Signed-off-by: Gabriel Adrian Samfira <[email protected]>
Co-authored-by: Tingluo Huang <[email protected]>
TingluoHuang and others added 21 commits June 18, 2024 11:28
* Bump runner to dotnet 8

* .
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ctions#3347)

Bumps [System.Security.Cryptography.Pkcs](https://github.com/dotnet/runtime) from 5.0.0 to 8.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v5.0.0...v8.0.0)

---
updated-dependencies:
- dependency-name: System.Security.Cryptography.Pkcs
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* redirect supported OS doc to public docs

* Anchor to appropriate OS heading

Co-authored-by: Patrick Ellis <[email protected]>

---------

Co-authored-by: Patrick Ellis <[email protected]>
* Update Docker to v27.1.1

* Update Dockerfile
* Revert "Upgrade dotnet sdk to v8.0.303 (actions#3388)"

This reverts commit dbcaa7c.

* Revert "Bump System.Security.Cryptography.Pkcs from 5.0.0 to 8.0.0 in /src (actions#3347)"

This reverts commit 3dab1f1.

* Revert "Upgrade dotnet sdk to v8.0.302 (actions#3346)"

This reverts commit 8f1c723.

* Revert "Bump runner to dotnet 8 (actions#3345)"

This reverts commit 1e74a81.
* Revert "Warn for soon to be deprecated OS versions (actions#3413)"

This reverts commit ae04147.

* Add .NET 8 OS compatibility test

* feedback
…n to match output, 3) modify output truncation length (actions#3427)
actions#3056)

* fix: add `git` and `curl` to default packages installed

Hi 👋🏼 

These packages are used in a ton of actions on the marketplace. It would be nice if they were installed and ready for use instead of having to install them with `apt-get` on every single Github workflow.

* Update Dockerfile

* Update images/Dockerfile

Co-authored-by: Guillermo Caracuel <[email protected]>

* Update images/Dockerfile

Co-authored-by: Tingluo Huang <[email protected]>

---------

Co-authored-by: Guillermo Caracuel <[email protected]>
Co-authored-by: Tingluo Huang <[email protected]>
@ChristopherHX ChristopherHX force-pushed the update-runner-fork-2a-fast-forward branch 3 times, most recently from 82fb7e8 to 6a475e9 Compare September 1, 2024 15:47
@ChristopherHX ChristopherHX force-pushed the update-runner-fork-2a-fast-forward branch from 6a475e9 to 16d82ce Compare September 1, 2024 18:05
@ChristopherHX ChristopherHX marked this pull request as ready for review September 1, 2024 18:41
@ChristopherHX ChristopherHX merged commit 16d82ce into main Sep 1, 2024
39 checks passed
@ChristopherHX ChristopherHX deleted the update-runner-fork-2a-fast-forward branch September 1, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.