Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Updates #500

Closed
wants to merge 11 commits into from
4 changes: 2 additions & 2 deletions .github/workflows/bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ jobs:
fail-fast: false # show all errors for each platform (vs. cancel jobs on error)
matrix:
include:
- os: ubuntu-latest
- os: ubuntu-22.04
cmake_args: "-DCMAKE_BUILD_TYPE=Release"
# - os: windows-2019
# cmake_args: ""
# - os: macos-latest
# - os: macos-13
# cmake_args: "-DCMAKE_BUILD_TYPE=Release"

steps:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/code-quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ env:
jobs:
clang_tidy:
name: "Run Code Quality Check: clang-tidy"
runs-on: ubuntu-latest
runs-on: ubuntu-22.04

steps:
- name: Install Linux Deps
Expand Down Expand Up @@ -60,7 +60,7 @@ jobs:

sonar_scan:
name: "Run Code Quality Check: sonar-scan"
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
env:
BUILD_WRAPPER_OUT_DIR: build_wrapper_output_directory # Directory where build-wrapper output will be placed

Expand Down Expand Up @@ -110,7 +110,7 @@ jobs:

code_ql:
name: "Run Code Quality Check: CodeQL"
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
if: ${{ github.event_name == 'push' }}

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
strategy:
fail-fast: false # show all errors for each platform (vs. cancel jobs on error)
matrix:
os: [ubuntu-latest, windows-2019, macos-latest]
os: [ubuntu-22.04, windows-2022, macos-13]

steps:
- name: Install Linux Deps
Expand Down
48 changes: 32 additions & 16 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,40 +30,49 @@ jobs:
"Test",
"Coverage",
]
os: [ubuntu-latest, windows-2022, macos-latest]
os: [ubuntu-22.04, windows-2022, macos-13]
include:
- name: "Test"
os: ubuntu-latest
os: ubuntu-22.04
cmake_args: "-DCMAKE_BUILD_TYPE=Release"
build_type: "Release"
- name: "Test"
os: windows-2022
cmake_args: "-DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl -G\"Ninja Multi-Config\""
build_type: "Release"
- name: "Coverage"
os: ubuntu-latest
os: ubuntu-22.04
cmake_args: "-DCODE_COVERAGE=ON -DCMAKE_BUILD_TYPE=Debug"
run_coverage: true
build_type: "Debug"
run_coverage: true
- name: "Coverage"
os: macos-latest
os: macos-13
cmake_args: "-DCODE_COVERAGE=ON -DCMAKE_BUILD_TYPE=Debug"
# run_coverage: true (this is breaking for some reason @TODO)
build_type: "Debug"
# run_coverage: true # (this is breaking for some reason @TODO)
- name: "Live GUI Test"
os: ubuntu-latest
os: ubuntu-22.04
tests: "live_gui_test"
cmake_args: "-DCODE_COVERAGE=ON -DCHOWDSP_BUILD_LIVE_GUI_TEST=ON -DCMAKE_BUILD_TYPE=Debug"
build_type: "Debug"
live_gui: true
run_coverage: true
build_type: "Debug"
exclude:
# so we don't break GitHub Actions concurrency limit
- name: "Test"
os: macos-latest
os: macos-13
- name: "Coverage"
os: windows-2022

steps:
- name: Vars Check
run: |
echo OS: ${{ matrix.os }}
echo cmake_args: ${{ matrix.cmake_args }}
echo build_type: ${{ matrix.build_type }}
echo run_coverage: ${{ matrix.run_coverage }}
echo tests: ${{ matrix.tests }}

- name: Install Linux Deps
if: runner.os == 'Linux'
run: |
Expand All @@ -80,6 +89,18 @@ jobs:
export HOMEBREW_NO_AUTO_UPDATE=1
brew install lcov

- name: Install Ninja
if: runner.os == 'Windows'
uses: seanmiddleditch/gha-setup-ninja@master

- name: Add msbuild to PATH
if: runner.os == 'Windows'
uses: microsoft/setup-msbuild@v2

- name: Setup MSVC devcmd
if: runner.os == 'Windows'
uses: ilammy/msvc-dev-cmd@v1

- name: Get latest CMake
uses: lukka/get-cmake@latest

Expand All @@ -97,18 +118,13 @@ jobs:

- name: Configure
working-directory: ${{env.WORK_DIR}}
env:
CMAKE_ARGS: ${{ matrix.cmake_args }}
shell: bash
run: cmake -Bbuild -DCHOWDSP_ENABLE_TESTING=ON $CMAKE_ARGS
run: cmake -Bbuild -DCHOWDSP_ENABLE_TESTING=ON ${{ matrix.cmake_args }}

- name: Build
working-directory: ${{env.WORK_DIR}}/build
shell: bash
env:
TEST_TARGETS: ${{ matrix.tests }}
BUILD_TYPE: ${{ matrix.build_type }}
run: cmake --build . --config $BUILD_TYPE --parallel 4 --target $TEST_TARGETS
run: cmake --build . --config ${{ matrix.build_type }} --parallel 4 --target ${{ matrix.tests }}

- name: "Run Tests: ${{ matrix.tests }}"
if: (! matrix.live_gui)
Expand Down
Loading