Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that log files are written to before crashing #495

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

jatinchowdhury18
Copy link
Contributor

No description provided.

Copy link

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ea0fb68) 90.00% compared to head (834317d) 90.00%.

Files Patch % Lines
...chowdsp_logging/Loggers/chowdsp_LogFileHelpers.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #495   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files         294      294           
  Lines        9582     9583    +1     
=======================================
+ Hits         8624     8625    +1     
  Misses        958      958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jatinchowdhury18 jatinchowdhury18 merged commit c8dbb90 into master Feb 20, 2024
28 of 29 checks passed
@jatinchowdhury18 jatinchowdhury18 deleted the log-fixes branch February 20, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant