Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spectrum Analyser Background Tasks Made Optional and Spectrum Analyser Tasks for Brickwall, SVF & BandSplitter #31

Merged
merged 16 commits into from
Jan 3, 2024
Merged

Spectrum Analyser Background Tasks Made Optional and Spectrum Analyser Tasks for Brickwall, SVF & BandSplitter #31

merged 16 commits into from
Jan 3, 2024

Conversation

RachelMaryamLocke
Copy link
Contributor

@RachelMaryamLocke RachelMaryamLocke commented Nov 30, 2023 •
edited
Loading

Screenshot 2023-12-19 at 22 00 23 Screenshot 2023-12-19 at 22 01 00

jatinchowdhury18
jatinchowdhury18 reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@jatinchowdhury18 jatinchowdhury18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're clamping the dynamic range of the spectrum here, which is causing the spectrum to still show when there's no audio being played. Maybe we want to remove that, or make it "tunable" in some way? Or maybe we should adjust the range of the spectrum plot so that we're seeing more of the useful features... not sure exactly what that would look like.

src/gui/Shared/SpectrumAnalyser.h Outdated Show resolved Hide resolved
src/gui/Shared/SpectrumAnalyser.cpp Outdated Show resolved Hide resolved
src/gui/Brickwall/BrickwallPlot.h Outdated Show resolved Hide resolved
src/dsp/Brickwall/BrickwallProcessor.h Outdated Show resolved Hide resolved
src/gui/Brickwall/BrickwallPlot.cpp Show resolved Hide resolved
@RachelMaryamLocke RachelMaryamLocke changed the title Spectrum Analyser Background Tasks Made Optional and Post EQ for Brickwall Spectrum Analyser Background Tasks Made Optional and Post EQ for Brickwall and SVF Dec 14, 2023
@RachelMaryamLocke RachelMaryamLocke changed the title Spectrum Analyser Background Tasks Made Optional and Post EQ for Brickwall and SVF Spectrum Analyser Background Tasks Made Optional and SpectrumAnalyser for Brickwall and SVF Dec 14, 2023
@RachelMaryamLocke RachelMaryamLocke changed the title Spectrum Analyser Background Tasks Made Optional and SpectrumAnalyser for Brickwall and SVF Spectrum Analyser Background Tasks Made Optional and Spectrum Analyser Tasks for Brickwall and SVF Dec 14, 2023
@RachelMaryamLocke RachelMaryamLocke changed the title Spectrum Analyser Background Tasks Made Optional and Spectrum Analyser Tasks for Brickwall and SVF Spectrum Analyser Background Tasks Made Optional and Spectrum Analyser Tasks for Brickwall, SVF & BandSplitter Dec 18, 2023
@jatinchowdhury18 jatinchowdhury18 force-pushed the spectrum_analyser_update branch from 117585c to 922e99d Compare January 3, 2024 22:29
@jatinchowdhury18 jatinchowdhury18 merged commit 2f36cdc into main Jan 3, 2024
@jatinchowdhury18 jatinchowdhury18 deleted the spectrum_analyser_update branch January 3, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jatinchowdhury18 jatinchowdhury18 jatinchowdhury18 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RachelMaryamLocke @jatinchowdhury18