-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go back to <4 as the python version upper limit #19080
Conversation
Pull Request Test Coverage Report for Build 12691960049Details
💛 - Coveralls |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Kyle should we undraft this? I still see < 3.13 in places. |
#19062 makes this a touch simpler. i was going to wait for that just to avoid thrash. note that i think there are going to be some other dep issues and this isn't meant to actually get us supporting python 3.13+. just not getting in the way of people trying to fiddle themselves. tl;dr, i expect to undraft it later today. |
So it seems I had misunderstood something when chatting with folks that had tried to run on 3.13+. I don't think that the pyinstaller bump really changed much after all. Sorry about that. Anyways, undrafted and ready to go pending CI and a review. |
To get things (almost)working with python3.13, I had to:
|
Purpose:
Current Behavior:
New Behavior:
Testing Notes:
Draft For: