Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go back to <4 as the python version upper limit #19080

Merged
merged 2 commits into from
Jan 10, 2025
Merged

go back to <4 as the python version upper limit #19080

merged 2 commits into from
Jan 10, 2025

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Dec 20, 2024

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

Draft For:

@altendky altendky requested a review from a team as a code owner December 20, 2024 21:12
@altendky altendky added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Dec 20, 2024
@altendky altendky requested a review from emlowe December 20, 2024 21:44
Copy link

coveralls-official bot commented Dec 21, 2024

Pull Request Test Coverage Report for Build 12691960049

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 62 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.04%) to 91.513%

Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.45%
chia/plotters/plotters.py 1 90.94%
chia/consensus/blockchain.py 2 94.14%
chia/full_node/full_node_api.py 2 84.77%
chia/rpc/rpc_server.py 3 88.24%
chia/timelord/timelord_launcher.py 4 89.29%
chia/wallet/wallet_node.py 6 87.96%
chia/plotters/madmax.py 6 44.58%
chia/full_node/full_node.py 6 86.36%
chia/server/node_discovery.py 7 79.85%
Totals Coverage Status
Change from base Build 12691593511: -0.04%
Covered Lines: 105318
Relevant Lines: 114904

💛 - Coveralls

@altendky altendky marked this pull request as draft December 31, 2024 14:22
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

@wjblanke
Copy link
Contributor

wjblanke commented Jan 8, 2025

Kyle should we undraft this? I still see < 3.13 in places.

@altendky
Copy link
Contributor Author

altendky commented Jan 8, 2025

#19062 makes this a touch simpler. i was going to wait for that just to avoid thrash. note that i think there are going to be some other dep issues and this isn't meant to actually get us supporting python 3.13+. just not getting in the way of people trying to fiddle themselves.

tl;dr, i expect to undraft it later today.

@altendky altendky closed this Jan 9, 2025
@altendky altendky reopened this Jan 9, 2025
@altendky altendky marked this pull request as ready for review January 9, 2025 14:30
@altendky
Copy link
Contributor Author

altendky commented Jan 9, 2025

So it seems I had misunderstood something when chatting with folks that had tried to run on 3.13+. I don't think that the pyinstaller bump really changed much after all. Sorry about that. Anyways, undrafted and ready to go pending CI and a review.

@pmaslana pmaslana merged commit 37deeaf into main Jan 10, 2025
717 checks passed
@pmaslana pmaslana deleted the less_than_4 branch January 10, 2025 17:20
@wallentx
Copy link
Contributor

So it seems I had misunderstood something when chatting with folks that had tried to run on 3.13+. I don't think that the pyinstaller bump really changed much after all. Sorry about that. Anyways, undrafted and ready to go pending CI and a review.

To get things (almost)working with python3.13, I had to:

  • update install.sh to let it work with 3.13
  • bump pyinstaller and typing-extensions 4.12.2 (it looks like you already bumped this in main)
  • edit this to include zstd in versions < 3.14
    zstd = [
    {version=">=1.5.5.1", python = "<3.12"},
    {version=">=1.5.5.1", python = "3.12", source="chia"},
    ]
  • This let me build, but when I would run chia start node I would get:
Exception ignored in: <function _SelectorTransport.__del__ at 0x7addfc29cfe0>
Traceback (most recent call last):
  File "/usr/lib/python3.13/asyncio/selector_events.py", line 872, in __del__
    self._server._detach(self)
TypeError: PausableServer._detach() takes 1 positional argument but 2 were given
Exception ignored in: <function _SelectorTransport.__del__ at 0x7addfc29cfe0>
at pypException ignored in: <function _SelectorTransport.__del__ at 0x7addfc29cfe0>
  • I read up and saw that there were changes to python3.13's implementation of asyncio, and wasn't sure if this was necessary/helpful, but I bumped these to the latest:
    aiofiles = ">=24.1.0" # Async IO for files
    aiohttp = ">=3.10.4" # HTTP server for full node rpc
    aiosqlite = ">=0.20.0" # asyncio wrapper for sqlite, to store blocks
  • After updating those, when running chia start node I would get:
Exception ignored in: <function _SelectorTransport.__del__ at 0x7c07ef7b4ea0>
Traceback (most recent call last):
  File "/usr/lib/python3.13/asyncio/selector_events.py", line 872, in __del__
    self._server._detach(self)
TypeError: PausableServer._detach() takes 1 positional argument but 2 were given

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants