CHIA-2109 Clarify cases when transactions filter is computed with just reward coins #19078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmineKhaldi
added
Changed
|
missing test coverage: looks good otherwise! |
AmineKhaldi
force-pushed
the
no_tx_filter_vs_filter_check_pass
branch
from
d4873e7 to
7c84f8e
Compare
arvidn
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
This allows us to request more clearly the computation of a transactions filter, both when the transaction block contains no transactions generator (block with only reward coins) and when it has one.
Current Behavior:
Requesting a transactions filter on the two cases of transaction blocks (with and without transactions generator) are not separated clearly.
New Behavior:
There are now two clear paths that requesting a transactions filter on a transaction block would go through.