Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-2091 Use boost v1.85 when compiling chiavdf from source on macos-intel #19065

Merged

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

This allows us to successfully compile chiavdf from source for now, until the underlying issue with newer boost versions is fixed.

Current Behavior:

CI failure: https://github.com/Chia-Network/chia-blockchain/actions/runs/12378217642/job/34549652480

New Behavior:

We are able to compile chiavdf from source on macos-intel and CI continues properly.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Dec 18, 2024
@AmineKhaldi AmineKhaldi self-assigned this Dec 18, 2024
Copy link

Pull Request Test Coverage Report for Build 12391757446

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 26 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.02%) to 91.523%

Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.45%
chia/wallet/wallet_node.py 1 88.24%
chia/_tests/core/util/test_lockfile.py 4 88.43%
chia/full_node/weight_proof.py 4 90.64%
chia/daemon/server.py 7 83.24%
chia/full_node/full_node.py 9 86.27%
Totals Coverage Status
Change from base Build 12381535704: -0.02%
Covered Lines: 104957
Relevant Lines: 114485

💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review December 18, 2024 13:45
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner December 18, 2024 13:45
@AmineKhaldi AmineKhaldi changed the title Use boost v1.85 when compiling chiavdf from source on macos-intel CHIA-2091 Use boost v1.85 when compiling chiavdf from source on macos-intel Dec 18, 2024
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought these changes were made to boost.asio years ago. maybe the old names were just deprecated

@hoffmang9 hoffmang9 merged commit 1951022 into Chia-Network:main Dec 18, 2024
360 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants