Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant block record conversion CHIA-1286 #18930

Merged
merged 4 commits into from
Jan 6, 2025
Merged

remove redundant block record conversion CHIA-1286 #18930

merged 4 commits into from
Jan 6, 2025
+22 −16

Conversation

almogdepaz
Copy link
Contributor

@almogdepaz almogdepaz commented Nov 25, 2024 •
edited
Loading

Purpose:

removing a redundant call to block_to_block_record by propegating the converted record into blockchain.add_block

@almogdepaz almogdepaz added low-priority A low priority bug which does not really have an effect on anything. full_node sync Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog labels Nov 25, 2024
@almogdepaz almogdepaz changed the title remove redundant block record conversion remove redundant block record conversion CHIA-1286 Nov 25, 2024
@almogdepaz almogdepaz removed the low-priority A low priority bug which does not really have an effect on anything. label Nov 25, 2024
@almogdepaz almogdepaz marked this pull request as ready for review January 6, 2025 14:34
@almogdepaz almogdepaz requested a review from a team as a code owner January 6, 2025 14:34
@almogdepaz almogdepaz requested a review from arvidn January 6, 2025 14:34
arvidn
arvidn reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some minor comments

chia/consensus/blockchain.py Show resolved Hide resolved
chia/consensus/blockchain.py Show resolved Hide resolved
chia/full_node/full_node.py Show resolved Hide resolved
chia/full_node/full_node.py Show resolved Hide resolved
@pmaslana pmaslana merged commit b6d5afc into main Jan 6, 2025
362 checks passed
@pmaslana pmaslana deleted the remove_redundant_conversion branch January 6, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog full_node sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@almogdepaz @arvidn @pmaslana