Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a class for the chia cli context data #18919

Merged
merged 14 commits into from
Dec 19, 2024
Merged

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Nov 21, 2024

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Nov 21, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Dec 13, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added merge_conflict Branch has conflicts that prevent merge to main and removed merge_conflict Branch has conflicts that prevent merge to main labels Dec 13, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added merge_conflict Branch has conflicts that prevent merge to main and removed merge_conflict Branch has conflicts that prevent merge to main labels Dec 13, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Dec 17, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added merge_conflict Branch has conflicts that prevent merge to main and removed merge_conflict Branch has conflicts that prevent merge to main labels Dec 17, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Dec 17, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@altendky altendky marked this pull request as ready for review December 18, 2024 13:24
@altendky altendky requested a review from a team as a code owner December 18, 2024 13:24
chia/cmds/cmd_classes.py Outdated Show resolved Hide resolved
chia/cmds/sim.py Show resolved Hide resolved
@altendky altendky requested a review from emlowe December 18, 2024 16:42
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/check_wallet_db.py 33.3% lines 402, 420
chia/cmds/chia.py 75.0% lines 120
chia/cmds/farm.py 33.3% lines 66, 100
chia/cmds/netspace.py 50.0% lines 50
chia/cmds/passphrase.py 33.3% lines 74, 102
chia/cmds/plots.py 14.3% lines 37, 136, 181, 205, 224, 230
chia/cmds/rpc.py 25.0% lines 107, 123, 181
chia/cmds/sim.py 10.0% lines 38-40, 76-77, 136, 181, 201, 218
chia/cmds/stop.py 50.0% lines 58
chia/cmds/wallet.py 93.3% lines 734
Total Missing Coverage
161 lines 28 lines 82%

Copy link

Pull Request Test Coverage Report for Build 12396153969

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 133 of 161 (82.61%) changed or added relevant lines in 28 files are covered.
  • 40 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.03%) to 91.515%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/cmds/chia.py 3 4 75.0%
chia/cmds/netspace.py 1 2 50.0%
chia/cmds/stop.py 1 2 50.0%
chia/cmds/wallet.py 14 15 93.33%
chia/cmds/check_wallet_db.py 1 3 33.33%
chia/cmds/farm.py 1 3 33.33%
chia/cmds/passphrase.py 1 3 33.33%
chia/cmds/rpc.py 1 4 25.0%
chia/cmds/plots.py 1 7 14.29%
chia/cmds/sim.py 1 10 10.0%
Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.45%
chia/cmds/plotnft_funcs.py 1 85.87%
chia/wallet/util/wallet_sync_utils.py 1 86.07%
chia/server/node_discovery.py 1 79.63%
chia/daemon/client.py 1 74.58%
chia/wallet/wallet_node.py 3 88.03%
chia/cmds/sim.py 4 57.55%
chia/full_node/weight_proof.py 4 90.64%
chia/daemon/server.py 7 83.24%
chia/full_node/full_node.py 17 85.86%
Totals Coverage Status
Change from base Build 12381535704: -0.03%
Covered Lines: 105000
Relevant Lines: 114543

💛 - Coveralls

@pmaslana pmaslana merged commit 9a0b572 into main Dec 19, 2024
363 of 364 checks passed
@pmaslana pmaslana deleted the chia_cli_context_class branch December 19, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants