[CHIA-1348] Port chia wallet coin commands to @chia_command framework
#18641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
Changed
Quexington
changed the title
chia wallet coin commands to @chia_command frameworkchia wallet coin commands to @chia_command framework
github-actions
bot
added
coverage-diff
merge_conflict
github-actions
bot
removed
the
merge_conflict
altendky
requested changes
Dec 11, 2024
altendky
reviewed
Dec 11, 2024
altendky
reviewed
Dec 12, 2024
Co-authored-by: Kyle Altendorf <[email protected]>
altendky
previously approved these changes
Dec 12, 2024
github-actions
bot
added
the
merge_conflict
github-actions
bot
removed
the
merge_conflict
|
emlowe
approved these changes
Dec 16, 2024
|
A followup that hits some of the negative test cases missing coverage would be useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(whitespace-less review will likely be beneficial)
This PR takes a step forward in porting existing wallet commands to the
@chia_commandframework currently in use for the signer commands. The primary benefit of this framework is that we can start writing integration tests with the command line interface at the top instead of the RPC so we can actually test the entire stack that a user utilizes when interacting with our application. It also comes with strong typing for CLI parameters and better code unity (right now the click options and the actual execution code live in separate places).The coin commands were chosen due to the smaller number of them and the recent attention that has been paid to their tests making it easy to port the commands right on top of those recent changes.