validate cached blockchains #18527
Draft
validate cached blockchains #18527
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
added
Added
…ocks match what we would have generated if it wasn't cached. This should make CI highlight whenever BlockTools changes some way of how chains are generated that alters the chain output. When this happens, we should also update the test-cache repo
arvidn
force-pushed
the
validate-test-cache
branch
from
96323d1 to
1acf025
Compare
|
This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties. |
github-actions
bot
added
the
stale-pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Prevent
BlockToolsto drift away from the chains stored intest-cache(i.e. ensure changes toBlockToolsare caught by CI so we can update the cache)When loading the cached test blockchains, check that the first few blocks match what we would have generated if it wasn't cached. This should make CI highlight whenever BlockTools changes some way of how chains are generated that alters the chain output. When this happens, we should also update the test-cache repo.
The test chains in
test-cachehave diverged from what's generated byBlockToolstoday. Probably at least in #18209Current Behavior:
If we find cached blockchains, we use them and assume they are right.
New Behavior:
If we find cached blockchains, we check the first 5 blocks to ensure they match what we would have generated, then use them.