Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor installer publish jobs #18220

Merged
merged 46 commits into from
Jul 15, 2024
Merged

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Jun 20, 2024

Purpose:

  • Make the publish jobs better aligned across platforms in preparation for switching to a reusable workflow to dedupe them
  • Clearly define file names one time and then reuse those single variables
  • Publish a single platform/arch/mode (cli vs. gui) per job to leverage matrixing across platforms

related:

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog CI CI changes labels Jun 20, 2024
Copy link

coveralls-official bot commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9645631001

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 146 unchanged lines in 27 files lost coverage.
  • Overall coverage decreased (-0.03%) to 90.902%

Files with Coverage Reduction New Missed Lines %
chia/data_layer/data_store.py 1 94.37%
chia/data_layer/download_data.py 1 83.58%
chia/_tests/simulation/test_simulation.py 1 96.5%
chia/_tests/util/test_priority_mutex.py 1 99.66%
chia/_tests/util/test_action_scope.py 1 99.01%
chia/_tests/core/mempool/test_mempool_manager.py 1 99.89%
chia/timelord/timelord_launcher.py 1 69.34%
chia/types/mempool_item.py 1 98.31%
chia/_tests/util/full_sync.py 1 88.95%
chia/daemon/client.py 1 73.94%
Totals Coverage Status
Change from base Build 9614112249: -0.03%
Covered Lines: 100242
Relevant Lines: 110214

💛 - Coveralls

@altendky altendky changed the title refactor installer publish workflows refactor installer publish jobs Jun 26, 2024
@altendky altendky marked this pull request as ready for review June 26, 2024 19:40
@altendky altendky requested a review from a team as a code owner June 26, 2024 19:40
@altendky altendky requested a review from cmmarslender June 26, 2024 20:57
Copy link

coveralls-official bot commented Jun 26, 2024

Pull Request Test Coverage Report for Build 9684148903

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 750 unchanged lines in 27 files lost coverage.
  • Overall coverage increased (+0.1%) to 90.985%

Files with Coverage Reduction New Missed Lines %
chia/_tests/wallet/rpc/test_wallet_rpc.py 1 99.68%
chia/_tests/wallet/dao_wallet/test_dao_wallets.py 1 99.95%
chia/wallet/wallet_node.py 1 88.79%
chia/cmds/chia.py 1 76.47%
chia/timelord/timelord_launcher.py 1 69.34%
chia/cmds/dao.py 1 99.54%
chia/rpc/util.py 2 98.89%
chia/_tests/pools/test_pool_rpc.py 2 99.08%
chia/wallet/util/clvm_streamable.py 2 98.1%
chia/_tests/pools/test_pool_cmdline.py 2 60.0%
Totals Coverage Status
Change from base Build 9650300892: 0.1%
Covered Lines: 101668
Relevant Lines: 111696

💛 - Coveralls

@altendky altendky marked this pull request as draft June 26, 2024 22:31
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

Pull Request Test Coverage Report for Build 9857706637

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.6%) to 91.502%

Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.5%
chia/rpc/rpc_server.py 1 87.71%
chia/daemon/client.py 1 73.94%
chia/wallet/wallet_node.py 2 88.86%
chia/full_node/full_node.py 6 85.64%
Totals Coverage Status
Change from base Build 9850517077: 0.6%
Covered Lines: 61677
Relevant Lines: 67329

💛 - Coveralls

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jul 10, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 10, 2024
@altendky altendky marked this pull request as ready for review July 11, 2024 15:33
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jul 11, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 12, 2024
@Starttoaster Starttoaster merged commit 0b6360f into main Jul 15, 2024
372 checks passed
@Starttoaster Starttoaster deleted the refactor_installer_build_workflows branch July 15, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog CI CI changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants