Remove unused code that attempts to read the output of the daemon #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqk
approved these changes
Nov 5, 2024
|
'This PR has been flagged as stale due to no activity for over 60 |
markelrod
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This old code was rendered unused by #2309 - but probably has not been used since earlier than that. Once the GUI starting launching the daemon via
chia start daemonit's not able to read the stdout as the process it launches is the chia CLI which then launches the daemon, so the GUI is one process removed from being able to read this.The daemon currently does output on stdout some JSON that was used by this code at some point in the past. That JSON code is no longer needed and is being removed in a chia-blockchain PR Chia-Network/chia-blockchain#18809
This PR doesn't need to wait for that to be merged, as the current GUI doesn't read this anyway.