Skip to content

Commit

Permalink
extension: Always use a real HTTP client in the ExtensionBuilder (z…
Browse files Browse the repository at this point in the history
…ed-industries#15514)

This PR makes it so we always construct a real HTTP client in the
`ExtensionBuilder`.

This used to be the case, but was inadvertently changed in
zed-industries#15470.

Release Notes:

- N/A
  • Loading branch information
maxdeviant authored Jul 30, 2024
1 parent a7ffc2b commit a08e020
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion crates/extension/src/extension_store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,12 @@ impl ExtensionStore {
extension_index: Default::default(),
installed_dir,
index_path,
builder: Arc::new(ExtensionBuilder::new(http_client.clone(), build_dir)),
builder: Arc::new(ExtensionBuilder::new(
// Construct a real HTTP client for the extension builder, as we
// don't want to use a fake one in the tests.
::http_client::client(None, http_client.proxy().cloned()),
build_dir,
)),
outstanding_operations: Default::default(),
modified_extensions: Default::default(),
reload_complete_senders: Vec::new(),
Expand Down

0 comments on commit a08e020

Please sign in to comment.