Documentation Updated for cQube-ingestion #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/01-code-setup.md
Outdated
| @@ -36,7 +36,7 @@ Create the environment (`.env`) file for connecting to the `timescaledb` docker | |||
|
|
|||
| ```bash | |||
| touch .env | |||
| echo "DATABASE_URL="postgres://timescaledb:postgrespassword@localhost:5432/postgres?sslmode=disable"" > .env | |||
| echo "DATABASE_URL="postgres://timescaledb:postgrespassword@localhost:8001/postgres?sslmode=disable"" > .env | |||
There was a problem hiding this comment.
small suggestion, here, this should be
// incorrect wrapping of strings
"DATABASE_URL="postgres://timescaledb:postgrespassword@localhost:8001/postgres?sslmode=disable""
// correct command
"DATABASE_URL"="postgres://timescaledb:postgrespassword@localhost:8001/postgres?sslmode=disable"
There was a problem hiding this comment.
Please fix the port here as well
techsavvyash
requested changes
Jul 9, 2023
docker-compose.yml
Outdated
| @@ -7,7 +7,7 @@ services: | |||
| image: timescale/timescaledb:2.0.0-pg12 | |||
| restart: always | |||
| ports: | |||
| - "5432:5432" | |||
| - "8001:5432" | |||
There was a problem hiding this comment.
Revert back to original ports
docker-compose.yml
Outdated
| @@ -17,7 +17,7 @@ services: | |||
| graphql-engine: | |||
| image: hasura/graphql-engine:latest | |||
| ports: | |||
| - "8080:8080" | |||
| - "8081:8080" | |||
There was a problem hiding this comment.
revert back to original port mapping.
docker-compose.yml
Outdated
| @@ -39,7 +39,7 @@ services: | |||
| pgpool-serv: | |||
| image: bitnami/pgpool | |||
| ports: | |||
| - 5433:5432 | |||
| - 8002:5432 | |||
There was a problem hiding this comment.
revert this to original port mapping.
docs/01-code-setup.md
Outdated
| @@ -36,7 +36,7 @@ Create the environment (`.env`) file for connecting to the `timescaledb` docker | |||
|
|
|||
| ```bash | |||
| touch .env | |||
| echo "DATABASE_URL="postgres://timescaledb:postgrespassword@localhost:5432/postgres?sslmode=disable"" > .env | |||
| echo "DATABASE_URL="postgres://timescaledb:postgrespassword@localhost:8001/postgres?sslmode=disable"" > .env | |||
There was a problem hiding this comment.
Please fix the port here as well
impl/c-qube/yarn.lock
Outdated
There was a problem hiding this comment.
remove this file from the changes
techsavvyash
requested changes
Oct 3, 2023
There was a problem hiding this comment.
what is this file? remove this.
There was a problem hiding this comment.
remove this, there should not be a yarn.lock at the root level
| @@ -36,7 +36,7 @@ Create the environment (`.env`) file for connecting to the `timescaledb` docker | |||
|
|
|||
| ```bash | |||
| touch .env | |||
| echo "DATABASE_URL="postgres://timescaledb:postgrespassword@localhost:5432/postgres?sslmode=disable"" > .env | |||
| echo "DATABASE_URL"="postgres://timescaledb:postgrespassword@localhost:8001/postgres?sslmode=disable" > .env | |||
There was a problem hiding this comment.
revert this back to original state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hii sir/ma'am, I have updated the Documentation for the project "cQube-ingestion" to setup the project, so that anyone can refer the Documentation provided in the directory cQube-ingestion/docs/01-code-setup.md
Looking forward for a response, ThankYou!