Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tile loading events for Voxels #12430

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

lukemckinstry
Copy link
Contributor

Description

Takes the following events from Cesium3DTileset and adds them to VoxelPrimitive

  • allTilesLoaded
  • initialTilesLoaded
  • loadProgress
  • tileLoad
  • tileUnload

Also makes VoxelPrimitive use Cesium3DTilesetStatistics class, but only makes use of 2 of the stats in the class so far.

ToDo

  • Did not carry over these event types
  • Still need to add tests, but these look straighforward to carry over from Cesium3dTilesetSpec to VoxelPrimitiveSpec.
  • move code to call events out of VoxelTraversal.printDebugInformation.

Issue number and link

related to #12297

Testing plan

Many events currently fire inside of VoxelTraversal.printDebugInformation. Enable this but comment out the last line of the function which logs the debug output so you can read the output from listeners you set up to listen to the new events.

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

Thank you for the pull request, @lukemckinstry!

✅ We can confirm we have a CLA on file for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant