Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply transform to content bounding volume #322

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Nov 23, 2024

Fixes #321

When there was a tile with a transform, and content that had a boundingVolume, then the transform was only applied to the tile bounding volume, but not to the content bounding volume. This was a leftover from the original/"legacy" bounding volume checks, and caused a BOUNDING_VOLUMES_INCONSISTENT to be reported erroneously.

Fortunately, it was an easy fix.

I did add a test for the case of bounding box objects. But in general, some parts of the "legacy" bounding volume containment checks could receive some additional coverage. It would be nice to cover the whole cartesian product of

  • box and box
  • box and sphere
  • box and region
  • sphere and box
  • sphere and sphere
  • sphere and region
  • region and box
  • region and sphere
  • region and region

both with and without transform, and a positive and a negative case, respectively. But I'd have to allocate more time to actually create these 36 tilesets...

@lilleyse lilleyse merged commit ccae675 into main Nov 24, 2024
2 checks passed
@lilleyse lilleyse deleted the content-bounding-volume-transform branch November 24, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BOUNDING_VOLUMES_INCONSISTENT false positive
2 participants