Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NGA_gpm validation #319

Merged
merged 26 commits into from
Nov 21, 2024
Merged

Add NGA_gpm validation #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
410fc56
Remove unnecessary type parameter
javagl Oct 23, 2024
8dfbd68
Fix typo in comment
javagl Oct 23, 2024
e06777b
First implementation of NGA_gpm
javagl Nov 6, 2024
de97c1b
Fix invalid type check. Formatting.
javagl Nov 7, 2024
60b0613
Validate extension when present
javagl Nov 7, 2024
5ada430
Move S2 specs data
javagl Nov 7, 2024
2802bd6
Fix missing refine in S2 spec data
javagl Nov 7, 2024
80085ae
Add missing S2 validation specs
javagl Nov 7, 2024
441df4c
Minor cleanup. Detect unnecessary epoch.
javagl Nov 9, 2024
f7ac277
Add consistency validation for 3D conformal
javagl Nov 9, 2024
9137ade
Cleanups, fixes, comments. Validate anchorPointMetadata.
javagl Nov 9, 2024
8604e5b
Add specs for GPM validation
javagl Nov 9, 2024
b6810cd
Remove fdescribe
javagl Nov 9, 2024
7a43fea
Handle missing flags in 3D conformal
javagl Nov 9, 2024
3fb45d8
Merge branch 'gpm-support-3d-tiles' into gpm-support-3d-tiles-specs
javagl Nov 9, 2024
9cb97f4
Add unit vector and orthonormality validation
javagl Nov 14, 2024
9f90ac5
Add date- and PPE source uniqueness validation
javagl Nov 16, 2024
0ed20b9
Formatting
javagl Nov 16, 2024
39ad0c9
Merge branch 'gpm-support-3d-tiles' into gpm-support-3d-tiles-specs
javagl Nov 16, 2024
ff12e3d
Fix wrong set construction
javagl Nov 16, 2024
90e0d76
Add specs for date, orthonormality, and PPE sources
javagl Nov 16, 2024
27a4ec7
Validate disallowed properties in modelCoordSystem
javagl Nov 16, 2024
c313f35
Stricter array length checks
javagl Nov 16, 2024
1a38b76
Specs for stricter array length checks
javagl Nov 16, 2024
19ead07
Minor wording fix in comment
javagl Nov 21, 2024
b08e047
Update epsilon for orthogonality check
javagl Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specs/MetadataSchemaValidationSpec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ describe("Metadata schema validation", function () {
"specs/data/schemas/schemaIdInvalidType.json"
);
expect(result.length).toEqual(1);
expect(result.get(0).type).toEqual("STRING_PATTERN_MISMATCH");
expect(result.get(0).type).toEqual("TYPE_MISMATCH");
});

it("detects issues in schemaIdInvalidValue", async function () {
Expand Down
1 change: 1 addition & 0 deletions ...ets/boundingVolumeS2/s2AndInvalidBox.json → ...ons/boundingVolumeS2/s2AndInvalidBox.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
],
"geometricError": 2.0,
"root": {
"refine": "ADD",
"geometricError": 1.0,
"boundingVolume": {
"box": [ 1, 2, 3],
Expand Down
1 change: 1 addition & 0 deletions ...gVolumeS2/s2MaximumHeightInvalidType.json → ...gVolumeS2/s2MaximumHeightInvalidType.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
],
"geometricError": 2.0,
"root": {
"refine": "ADD",
"geometricError": 1.0,
"boundingVolume": {
"extensions": {
Expand Down
1 change: 1 addition & 0 deletions ...inimumHeightGreaterThanMaximumHeight.json → ...inimumHeightGreaterThanMaximumHeight.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
],
"geometricError": 2.0,
"root": {
"refine": "ADD",
"geometricError": 1.0,
"boundingVolume": {
"extensions": {
Expand Down
1 change: 1 addition & 0 deletions ...gVolumeS2/s2MinimumHeightInvalidType.json → ...gVolumeS2/s2MinimumHeightInvalidType.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
],
"geometricError": 2.0,
"root": {
"refine": "ADD",
"geometricError": 1.0,
"boundingVolume": {
"extensions": {
Expand Down
1 change: 1 addition & 0 deletions .../boundingVolumeS2/s2TokenInvalidType.json → .../boundingVolumeS2/s2TokenInvalidType.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
],
"geometricError": 2.0,
"root": {
"refine": "ADD",
"geometricError": 1.0,
"boundingVolume": {
"extensions": {
Expand Down
1 change: 1 addition & 0 deletions ...boundingVolumeS2/s2TokenInvalidValue.json → ...boundingVolumeS2/s2TokenInvalidValue.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
],
"geometricError": 2.0,
"root": {
"refine": "ADD",
"geometricError": 1.0,
"boundingVolume": {
"extensions": {
Expand Down
1 change: 1 addition & 0 deletions ...sets/boundingVolumeS2/s2TokenMissing.json → ...ions/boundingVolumeS2/s2TokenMissing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
],
"geometricError": 2.0,
"root": {
"refine": "ADD",
"geometricError": 1.0,
"boundingVolume": {
"extensions": {
Expand Down
1 change: 1 addition & 0 deletions .../boundingVolumeS2/validTilesetWithS2.json → .../boundingVolumeS2/validTilesetWithS2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
],
"geometricError": 2.0,
"root": {
"refine": "ADD",
"geometricError": 1.0,
"boundingVolume": {
"extensions": {
Expand Down
176 changes: 176 additions & 0 deletions specs/data/extensions/gpm/anchorPointMetadataContentIndexInvalidType.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,176 @@
{
"asset": {
"version": "1.1"
},
"geometricError": 2.0,
"root": {
"refine": "REPLACE",
"boundingVolume": {
"box": [0.5, 0.5, 0.5, 0.5, 0.0, 0.0, 0.0, 0.5, 0.0, 0.0, 0.0, 0.5]
},
"geometricError": 1.0
},
"extensionsUsed": ["NGA_gpm"],
"extensions": {
"NGA_gpm": {
"anchorPointMetadata": {
"placementType": "SeparateContent",
"contentIndex": "NOT_A_NUMBER"
},
"masterRecord": {
"version": "1.2i",
"implementation": "Example",
"modelCoordSystem": {
"mcsType": "UTM",
"crsHorizontalUtm": {
"id": 32601
},
"crsVertical": {
"name": "Example Reference System",
"orgWithId": {
"organization": "EPSG",
"systemId": "Example System ID"
},
"epoch": 1
}
},
"idInformation": {
"datasetId": "exportid",
"referenceDateTime": "2024-04-29T11:21:49"
},
"datasetExtentInformation": {
"origin": [912996.5952063048, -5541794.593278977, 3012483.770173006],
"lsrAxisUnitVectors": [
[-0.0743933049314506, 0.4697008438610212, 0.8796855992100932],
[0.9868514414437406, 0.16160517449656873, -0.0028284441562802665],
[-0.14303538712009904, 0.8682099573522005, -0.47513403160149828]
],
"lsrLengths": [
5984.896982990946, 6337.485178905554, 99.99999999975178
]
},
"collectionRecordList": [
{
"collectionId": "collection id",
"platformId": "platform id",
"sensorRecords": [
{
"sensorId": "sensorid",
"sensorType": "sensortype",
"sensorMode": "sensormode",
"collectionUnitRecords": [
{
"referenceDateTime": "2024-04-29T11:21:49",
"collectionUnitId": "cuid",
"pointSourceId": 0,
"extentInformation": {
"origin": [
912996.5952063048, -5541794.593278977, 3012483.770173006
],
"lsrAxisUnitVectors": [
[
-0.0743933049314506, 0.4697008438610212,
0.8796855992100932
],
[
0.9868514414437406, 0.16160517449656873,
-0.0028284441562802665
],
[
-0.14303538712009904, 0.8682099573522005,
-0.47513403160149828
]
],
"lsrLengths": [
5984.896982990946, 6337.485178905554, 99.99999999975178
]
}
}
]
}
]
}
]
},
"unmodeledErrorRecord": {
"uniqueId": "unmodeled_error",
"corrRotationThetas": [0.0, 0.0, 0.0],
"corrParams": [
{
"A": 1.0,
"alpha": 0.99,
"beta": 0.0,
"T": 10000.0
},
{
"A": 1.0,
"alpha": 0.99,
"beta": 0.0,
"T": 10000.0
},
{
"A": 1.0,
"alpha": 0.99,
"beta": 0.0,
"T": 10000.0
}
],
"posts": [
{
"position": [12.34, 23.45, 34.56],
"covariance": [
0.1833647900304413, -0.093582914309524, 0.4550734755685732,
0.0572007221435672, -0.18392374133036396, 0.27486040919852534
]
}
]
},
"interpolationParams": {
"interpolationMode": "IDW",
"interpNumPosts": 6,
"dampeningParam": 250.0
},
"interTileCorrelationGroups": [
{
"groupFlags": [true, true, true],
"rotationThetas": [0.0, 0.0, 0.0],
"params": [
{
"A": 1.0,
"alpha": 0.99,
"beta": 0.0,
"T": 10000.0
},
{
"A": 1.0,
"alpha": 0.99,
"beta": 0.0,
"T": 10000.0
},
{
"A": 1.0,
"alpha": 0.99,
"beta": 0.0,
"T": 10000.0
}
]
}
],
"ppeManifest": [
{
"source": "SIGZ"
},
{
"source": "SIGR"
}
],
"threeDimConformalParams": {
"flags": [true, false, true, false, true, false, true],
"recentering": [1.2, 2.3, 3.4],
"normalizingScaleFactor": 1.2,
"parameters": [0, 1, 2, 3],
"covariance": [0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 1.0]
}
}
}
}
Loading
Loading