Fixed the broken keadm e2e task #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdgetrf
reviewed
Dec 17, 2021
| @@ -119,7 +119,8 @@ func installCRDs(ks *K8SInstTool) error { | |||
| "router": {"router/router_v1_rule.yaml", | |||
| "router/router_v1_ruleEndpoint.yaml"}, | |||
| } | |||
| version := fmt.Sprintf("%d.%d", ks.ToolVersion.Major, ks.ToolVersion.Minor) | |||
| //version := fmt.Sprintf("%d.%d", ks.ToolVersion.Major, ks.ToolVersion.Minor) | |||
There was a problem hiding this comment.
please remove the comment code.
pdgetrf
approved these changes
Dec 17, 2021
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keadm installer tends to download crd files from kube edge NOT Fornax.
Please refer to https://github.com/CentaurusInfra/fornax/blob/main/keadm/cmd/keadm/app/cmd/util/common.go#L69. It used to work until there is a new version v1.9.0 added to https://kubeedge.io/latestversion. For the version v1.9.0, there is a change kubeedge/kubeedge@c39927e#diff-37aa47f76f3a524adab02885d1b0deaade11da7c00eee11a4b0e1486e7015b67 which updated apiVersion: apiextensions.k8s.io/v1beta1 to apiVersion: apiextensions.k8s.io/v1.
A temp solution is changing v1.9.0 to v1.8 which does not have the apiVersion change.
If we updated the wrong KubeEdgeCRDDownloadURL to our Fornax repo, there will be other issues caused by incomplete Fornax code changes, such as unmarshall tfjobCRD.