Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up tests by parallelization using pytest-split #486

Merged
merged 10 commits into from
Aug 20, 2024

Conversation

kamronald
Copy link
Collaborator

Summary

Major changes:

Add pytest-split as a dependency during testing to parallelize the test suite

Todos

Checklist

  • All existing tests pass.
  • Tests have been added for any new features/fixes.
  • Docstrings have been added in the Google docstring format.

@kamronald kamronald changed the title Speed up tests by parallelization using pytest-split [WIP] Speed up tests by parallelization using pytest-split Aug 8, 2024
Remove "max-parallel" and put split as a key within matrix
Trying to get it to run properly on Github actions
@kamronald
Copy link
Collaborator Author

kamronald commented Aug 14, 2024

Hey @lbluque and @qchempku2017, are either of you able to access the branch protection rules? Currently the test(3.9) checks on the Github actions workflow is not running as expected. Just says "Expected - Waiting for status to be reported"

I'm wondering if I can remove that test somehow, but am not able to manage branch protection rules.

@kamronald kamronald requested a review from lbluque August 14, 2024 05:20
@qchempku2017
Copy link
Collaborator

Hey @lbluque and @qchempku2017, are either of you able to access the branch protection rules? Currently the test(3.9) checks on the Github actions workflow is not running as expected. Just says "Expected - Waiting for status to be reported"

I'm wondering if I can remove that test somehow, but am not able to manage branch protection rules.

@kamronald Hi Ronald I‘m really eager to help, but I really have no idea about where to start from. @lbluque Would you mind having a look at the issue Ronald mentioned and teach us how to fix it?

@kamronald
Copy link
Collaborator Author

So the issue I have is discussed here: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/managing-a-branch-protection-rule
I am not able to see the branch protection rules, but perhaps @lbluque or @qchempku2017 you guys can?

@lbluque
Copy link
Collaborator

lbluque commented Aug 20, 2024

Hi @kamronald, I made you Admin, can you check if you can see branch protection rules now?

@kamronald kamronald changed the title [WIP] Speed up tests by parallelization using pytest-split Speed up tests by parallelization using pytest-split Aug 20, 2024
@kamronald kamronald merged commit b3901ed into CederGroupHub:main Aug 20, 2024
27 checks passed
@kamronald kamronald deleted the parallelize_tests branch August 20, 2024 21:11
@kamronald
Copy link
Collaborator Author

Yes @lbluque can see them now and made some changes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants