Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A0-3755: Faucet cleaup #9

Merged
merged 6 commits into from
Jan 2, 2024
Merged

A0-3755: Faucet cleaup #9

merged 6 commits into from
Jan 2, 2024

Conversation

Marcin-Radecki
Copy link
Collaborator

This PR is required work before fixing bug in which RPC node gets restarted, and faucet remains in an undefined state and only restart helps. So in this PR we

  • bump polkadot-js lib and all its deps (as per upstream) to see if this problem is gone. Btw issue is not reproducible locally, but only on our infra, so we need to have some officially built version from alephzero branch
  • remove all not required deployment files
  • update ES lint settings (thus they are more restrictive now)
  • update dockerfile to be on Node 20
  • update worfklows to have basics:
    • linter, build on PR
    • build and push to ECR on alephzero commit
    • deploy to Testnet on demand
    • yaml linter and validator on PR
  • removed entirely Bot functionality, which we don't use anyway
  • support for balances.transfer removal from runtime (change backwards compatible)

Testing: tested changes locally (sending token works)

Post-merge steps:

  • make main default branch: this requires merging alephzero to main branches and then changing repo settings. We won't update from upstream most likely as this app is very simple now and pretty much won't be changed a lot.
  • change repo name to azero-faucet, as there's no Matrix functionality anymore in it

@Marcin-Radecki Marcin-Radecki marked this pull request as ready for review December 22, 2023 13:28
Copy link

@Kosiare Kosiare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (checked only workflow and related changes)

@Marcin-Radecki Marcin-Radecki merged commit c0d5535 into alephzero Jan 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants