Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature](mlu-ops): fix version_pre_chek #929

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

chqy99
Copy link
Collaborator

@chqy99 chqy99 commented Jan 19, 2024

Thanks for your contribution and we appreciate it a lot. 🚀🚀

1. Motivation

1.proto 3.9.0版本可以正常编译,但之前限制最高版本为3.8.0
2.版本预检查不通过,应该报warning

2. Modification

1.proto 的限制修改为最低版本为3.6.0
2.“exit强制退出”改成报warning

3. Test Report

@chqy99 chqy99 force-pushed the fix_version_pre_check branch 2 times, most recently from e0556a9 to 7379434 Compare January 19, 2024 10:13
@PetrelYy PetrelYy added this to the v1.0.0 milestone Jan 19, 2024
version_pre_check.py Outdated Show resolved Hide resolved
@chqy99 chqy99 changed the title [feature](mlu-ops): fix the check of protoc version [feature](mlu-ops): fix version_pre_chek Jan 19, 2024
@chqy99 chqy99 force-pushed the fix_version_pre_check branch from 7379434 to eb65f9b Compare January 19, 2024 10:30
@chqy99 chqy99 force-pushed the fix_version_pre_check branch from eb65f9b to 3dae7a3 Compare January 19, 2024 10:38
@Unireverse Unireverse merged commit 3f5b4ff into Cambricon:master Jan 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants