Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature](bangc-ops): add concat binary operator. #872

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

zhengleiZL
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. 🚀🚀

1. Motivation

将concat算子以二进制形式合入mluops

2. Modification

增加concat算子

3. Test Report

If you want to know how to do operator testing, you can see GTest-User-Guide-zh.

3.1 Modification Details

3.1.1 Accuracy Acceptance Standard

For static threshold standard details, see: MLU-OPS Accuracy Acceptance Standard.

  • static threshold
    • diff3
      • mlu diff3 == 0
      • mlu diff3_1 == 0
      • mlu diff3_2 == 0

3.1.2 Operator Scheme checklist

  • Supported hardware
    • MLU370
    • MLU590

3.2 Accuracy Test

3.2.1 Accuracy Test

If you have checked the following items, please tick the relevant box.

  • Data type test (e.g. float32/int8)
  • Multi-dimensional tensor test
  • Layout test
  • Different size/integer remainder end segment/alignment misalignment test
  • Zero dimensional tensor test/zero element test
  • stability test
  • Multiple platform test
  • Gen_case module test, see: Gencase-User-Guide-zh
  • Nan/INF tests
  • Bug fix tests
  • For memory leak check details, see: GTest-User-Guide-zh
  • For code coverage check details, see: GTest-User-Guide-zh
  • For I/O calculation efficiency check details, see: MLU-OPS-Performance-Acceptance-Standard

3.2.2 Parameter Check

Test Point-1: When a new operator is submitted, the test points are given and the test results are stated. Acceptance Standard: Normal error.

Please fill your test results(Error Message) in here, ...

Test Point-2: Whether illegal parameters are passed. Acceptance Standard: Normal error.

Test results...

3.3 Performance Test

See MLU-OPS Performance Acceptance Standard for details.

Platform:MLU370

[----------] Global test environment tear-down
[ SUMMARY  ] Total 131 cases of 79 op(s).
ALL PASSED.
[==========] 131 test cases from 79 test suites ran. (30884 ms total)
[  PASSED  ] 131 test cases.

3.4 Summary Analysis

Please give a brief overview here, if you want to note and summarize the content.

@zhengleiZL zhengleiZL force-pushed the binary-op-concat branch 2 times, most recently from 7840df0 to 30baf4e Compare October 25, 2023 10:17
Copy link
Collaborator

@SunsadYaofas SunsadYaofas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PetrelYy PetrelYy added this to the v0.10.0 milestone Oct 26, 2023
@PetrelYy PetrelYy merged commit a0b75eb into Cambricon:master Oct 26, 2023
1 check passed
@PetrelYy PetrelYy added the BANGC label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants