[Feature](bangc-ops): use fill_v3 instead of fill_zeros #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahxn0
approved these changes
Oct 16, 2023
DanieeelLiu
approved these changes
Oct 16, 2023
PetrelYy
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. 🚀🚀
1. Motivation
mlu_op.h 中没有注册 fill_zeros ，有二进制算子 fill 后，host端的赋0操作统一为 fill_v3。
2. Modification
使用到 fill_zeros 的地方，替换为 fill_v3
删除 kernels/fill_zero/
3. Test Report
MLU370、MLU590原测例全部通过