Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature](bangc-ops): add maximum input size check for box_iou_rotated. #850

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

DanieeelLiu
Copy link
Collaborator

@DanieeelLiu DanieeelLiu commented Oct 9, 2023

Thanks for your contribution and we appreciate it a lot. 🚀🚀

1. Motivation

add maximum input size check for box_iou_rotated

2. Modification

bangc-ops/kernels/box_iou_rotated/box_iou_rotated.cpp

3. Test Report

If you want to know how to do operator testing, you can see GTest-User-Guide-zh.

3.1 Modification Details

3.1.1 Accuracy Acceptance Standard

For static threshold standard details, see: MLU-OPS Accuracy Acceptance Standard.

  • static threshold
    • diff1
      • float32 mlu diff1 <= 1e-5
      • float32 mlu diff1 <= 3e-3
      • float16 mlu diff1 <= 3e-3
    • diff2
      • float32 mlu diff2 <= 1e-5
      • float32 mlu diff2 <= 3e-3
      • float16 mlu diff2 <= 3e-3
    • diff3
      • mlu diff3 == 0
      • mlu diff3_1 == 0
      • mlu diff3_2 == 0
  • dynamic threshold
    • diff1: mlu diff1 <= max(baseline diff1 * 10, static threshold)
    • diff2: mlu diff2 <= max(baseline diff2 * 10, static threshold)
    • diff3: mlu diff3 <= max(baseline diff3 * 10, static threshold)
      • float32, threshold = 1e-5
      • float16, threshold = 1e-3

3.1.2 Operator Scheme checklist

skip

3.2 Accuracy Test

3.2.1 Accuracy Test

skip

3.2.2 Parameter Check

Test Point-1: When a new operator is submitted, the test points are given and the test results are stated. Acceptance Standard: Normal error.

[2023-10-9 19:16:1] [MLUOP] [Error]:[mluOpBoxIouRotated] Check failed: If it is aligned mode, box1_desc->dims[0] should less than or equal to 10,000,000. But now is 20000001.
[2023-10-9 19:16:1] [MLUOP] [Error]:"MLUOP_STATUS_BAD_PARAM in mluOpBoxIouRotated(handle_, mode, aligned, box1, dev_box1, box2, dev_box2, ious, dev_ious)"

Test Point-2: Whether illegal parameters are passed. Acceptance Standard: Normal error.

[2023-10-9 19:11:59] [MLUOP] [Error]:[mluOpBoxIouRotated] Check failed: If it is aligned mode, box1_desc->dims[0] * box2_desc->dims[0] should less than or equal to 10,000,000. But now is 50000000.
[2023-10-9 19:11:59] [MLUOP] [Error]:"MLUOP_STATUS_BAD_PARAM in mluOpBoxIouRotated(handle_, mode, aligned, box1, dev_box1, box2, dev_box2, ious, dev_ious)"

3.3 Performance Test

skip

3.4 Summary Analysis

release_test/release_temp/benchmark 370/590 passed.

@DanieeelLiu DanieeelLiu force-pushed the box_iou_rotated_check_size branch from 754095e to 06c4cb3 Compare October 10, 2023 03:19
@PetrelYy PetrelYy added the BANGC label Oct 10, 2023
@PetrelYy PetrelYy added this to the v0.9.0 milestone Oct 10, 2023
@DanieeelLiu DanieeelLiu force-pushed the box_iou_rotated_check_size branch from 06c4cb3 to 551e5d7 Compare October 10, 2023 07:28
@duzekunKTH duzekunKTH merged commit 0d3a1be into Cambricon:master Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants