-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature](bangc-ops): add Sybn op. #844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuer-cn
force-pushed
the
syncbn_forward
branch
2 times, most recently
from
September 25, 2023 08:42
652a771
to
797400d
Compare
PetrelYy
reviewed
Sep 25, 2023
PetrelYy
reviewed
Sep 25, 2023
PetrelYy
reviewed
Sep 25, 2023
bangc-ops/kernels/sync_batch_norm_backward_elemt/sync_batch_norm_backward_elemt.cpp
Outdated
Show resolved
Hide resolved
PetrelYy
reviewed
Sep 25, 2023
PetrelYy
reviewed
Sep 25, 2023
PetrelYy
reviewed
Sep 25, 2023
PetrelYy
reviewed
Sep 25, 2023
PetrelYy
reviewed
Sep 25, 2023
..._op_gtest/pb_gtest/src/zoo/sync_batch_norm_backward_elemt/sync_batch_norm_backward_elemt.cpp
Show resolved
Hide resolved
PetrelYy
reviewed
Sep 25, 2023
..._op_gtest/pb_gtest/src/zoo/sync_batch_norm_backward_elemt/sync_batch_norm_backward_elemt.cpp
Outdated
Show resolved
Hide resolved
PetrelYy
reviewed
Sep 25, 2023
.../src/zoo/sync_batchnorm_gather_stats_with_counts/sync_batchnorm_gather_stats_with_counts.cpp
Outdated
Show resolved
Hide resolved
PetrelYy
reviewed
Sep 25, 2023
...st/src/zoo/sync_batchnorm_gather_stats_with_counts/sync_batchnorm_gather_stats_with_counts.h
Show resolved
Hide resolved
PetrelYy
reviewed
Sep 25, 2023
bangc-ops/test/mlu_op_gtest/pb_gtest/src/zoo/sync_batchnorm_stats/test_case/case_0.prototxt
Show resolved
Hide resolved
yuer-cn
force-pushed
the
syncbn_forward
branch
2 times, most recently
from
September 26, 2023 03:08
4f753a5
to
1c8f8e4
Compare
duzekunKTH
reviewed
Sep 27, 2023
..._op_gtest/pb_gtest/src/zoo/sync_batch_norm_backward_elemt/sync_batch_norm_backward_elemt.cpp
Outdated
Show resolved
Hide resolved
duzekunKTH
reviewed
Sep 27, 2023
...gtest/pb_gtest/src/zoo/sync_batchnorm_backward_elemt_v2/sync_batchnorm_backward_elemt_v2.cpp
Outdated
Show resolved
Hide resolved
duzekunKTH
reviewed
Sep 27, 2023
bangc-ops/test/mlu_op_gtest/pb_gtest/src/zoo/sync_batchnorm_elemt/sync_batchnorm_elemt.cpp
Outdated
Show resolved
Hide resolved
duzekunKTH
reviewed
Sep 27, 2023
.../src/zoo/sync_batchnorm_gather_stats_with_counts/sync_batchnorm_gather_stats_with_counts.cpp
Outdated
Show resolved
Hide resolved
duzekunKTH
reviewed
Sep 27, 2023
bangc-ops/test/mlu_op_gtest/pb_gtest/src/zoo/sync_batchnorm_stats/sync_batchnorm_stats.cpp
Outdated
Show resolved
Hide resolved
PetrelYy
reviewed
Sep 27, 2023
yuer-cn
force-pushed
the
syncbn_forward
branch
from
September 27, 2023 06:50
a3eb491
to
72bf32d
Compare
AquamarineSu
approved these changes
Sep 27, 2023
duzekunKTH
approved these changes
Sep 27, 2023
PetrelYy
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. 🚀🚀
1. Motivation
将sybn6个小算子以二进制形式合入mluops。
2. Modification
增加算子sync_batch_norm_backward_elemt,sync_batchnorm_backward_elemt_v2,sync_batchnorm_backward_reduce,
sync_batchnorm_elemt,sync_batchnorm_gather_stats_with_counts,sync_batchnorm_stats。
3. Test Report
If you want to know how to do operator testing, you can see GTest-User-Guide-zh.
3.1 Modification Details
3.1.1 Accuracy Acceptance Standard
For static threshold standard details, see: MLU-OPS Accuracy Acceptance Standard.
3.1.2 Operator Scheme checklist
3.2 Accuracy Test
3.2.1 Accuracy Test
If you have checked the following items, please tick the relevant box.
3.2.2 Parameter Check
Test Point-1:
When a new operator is submitted, the test points are given and the test results are stated
. Acceptance Standard:Normal error
.Test Point-2:
Whether illegal parameters are passed
. Acceptance Standard:Normal error
.3.3 Performance Test
See MLU-OPS Performance Acceptance Standard for details.
Platform:MLU370
Platform:MLU590
3.4 Summary Analysis
Please give a brief overview here, if you want to note and summarize the content.