-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature](mluOpCore): access variable in tensor struct through function in tensor.cpp and tensor.h #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nth-BYTE
force-pushed
the
nl21427_2
branch
3 times, most recently
from
November 22, 2024 10:00
aedefba
to
abfc867
Compare
zhouyue624
reviewed
Nov 27, 2024
zhouyue624
reviewed
Nov 27, 2024
zhouyue624
reviewed
Nov 27, 2024
zhouyue624
reviewed
Nov 27, 2024
zhouyue624
reviewed
Nov 27, 2024
nth-BYTE
force-pushed
the
nl21427_2
branch
7 times, most recently
from
December 2, 2024 10:03
fbd3d4e
to
a6000ac
Compare
jerryjiahaha
reviewed
Dec 2, 2024
jerryjiahaha
reviewed
Dec 2, 2024
jerryjiahaha
reviewed
Dec 2, 2024
jerryjiahaha
reviewed
Dec 2, 2024
jerryjiahaha
reviewed
Dec 2, 2024
nth-BYTE
force-pushed
the
nl21427_2
branch
3 times, most recently
from
December 3, 2024 08:05
8057c4c
to
45ae0ee
Compare
… tensor.cpp and tensor.h
nth-BYTE
force-pushed
the
nl21427_2
branch
2 times, most recently
from
December 4, 2024 04:18
772ef6e
to
22dee50
Compare
… tensor.cpp and tensor.h
jerryjiahaha
approved these changes
Dec 10, 2024
zhouyue624
approved these changes
Dec 17, 2024
PetrelYy
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. 🚀🚀
1. Motivation
Please describe your motivation and the goal you want to achieve through this pull request.
2. Modification
In mluOpTensorStruct , pubilc variables have been changed into private variables, except those will be removed in future, e.g. position,positions,scale,scales,offset,offsets. And then, some unused methods are deleted ,including tensorDimN,tensorDimC,tensorDimH,tensorDimW
3. Test Report
If you want to know how to do operator testing, you can see GTest-User-Guide-zh.
3.1 Modification Details
3.1.1 Accuracy Acceptance Standard
For static threshold standard details, see: MLU-OPS™ Accuracy Acceptance Standard.
3.1.2 Operator Scheme checklist
3.2 Accuracy Test
3.2.1 Accuracy Test
If you have checked the following items, please tick the relevant box.
3.2.2 Parameter Check
Test Point-1:
When a new operator is submitted, the test points are given and the test results are stated
. Acceptance Standard:Normal error
.Test Point-2:
Whether illegal parameters are passed
. Acceptance Standard:Normal error
.3.3 Performance Test
See MLU-OPS™ Performance Acceptance Standard for details.
Platform:MLU370
Platform:MLU590
3.4 Summary Analysis
Please give a brief overview here, if you want to note and summarize the content.