Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature](mluOpRoiAlignRotatedForward): Refactor roi align rotated forward #1138

Merged

Conversation

chqy99
Copy link
Collaborator

@chqy99 chqy99 commented Nov 5, 2024

Thanks for your contribution and we appreciate it a lot. 🚀🚀

1. Motivation

Please describe your motivation and the goal you want to achieve through this pull request.

2. Modification

Please briefly describe what modification is made in this pull request, and indicate where to make the modification.

Are new test cases added? If so, please post the corresponding generator-PR link here.

3. Test Report

If you want to know how to do operator testing, you can see GTest-User-Guide-zh.

3.1 Modification Details

@chqy99 chqy99 changed the title Refactor roi align rotated forward [Feature](mluOpRoiAlignRotatedForward): Refactor roi align rotated forward Nov 5, 2024
@chqy99 chqy99 force-pushed the refactor_roi_align_rotated_forward branch 2 times, most recently from bad8afb to 2aa9f82 Compare November 5, 2024 09:57
@chqy99 chqy99 force-pushed the refactor_roi_align_rotated_forward branch 2 times, most recently from 185bfef to e2fa190 Compare November 19, 2024 06:31
@mahxn0
Copy link
Collaborator

mahxn0 commented Nov 19, 2024

  1. 4次gather,每次gather一个点 可以修改为一次gather 4个点,看看是否有性能优化

@mahxn0
Copy link
Collaborator

mahxn0 commented Nov 19, 2024

  1. 坐标计算部分向量化实现下

@chqy99
Copy link
Collaborator Author

chqy99 commented Nov 19, 2024

  1. 4次gather,每次gather一个点 可以修改为一次gather 4个点,看看是否有性能优化

对于数据量较小的情况性能提升明显,10 % ~ 20 %

@chqy99 chqy99 force-pushed the refactor_roi_align_rotated_forward branch from b937fa6 to 2cc627e Compare November 19, 2024 10:56
@chqy99 chqy99 force-pushed the refactor_roi_align_rotated_forward branch from 22f8ecb to d1425ce Compare November 25, 2024 02:23
Copy link
Collaborator

@DanieeelLiu DanieeelLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chqy99 chqy99 force-pushed the refactor_roi_align_rotated_forward branch from d1425ce to 63caf1a Compare November 25, 2024 02:30
@mahxn0
Copy link
Collaborator

mahxn0 commented Nov 25, 2024

LGTM

@chqy99 chqy99 force-pushed the refactor_roi_align_rotated_forward branch from ebb739a to 84fb471 Compare November 25, 2024 03:09
@duzekunKTH duzekunKTH merged commit 06721fb into Cambricon:master Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants