Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature](mluOpSgetrf2): add LU parameter #105

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Feature](mluOpSgetrf2): add LU parameter #105

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a63a573
add LU parameter
Chuancysun Nov 16, 2024
b76f200
[Fix](mluOpXgetrf):rename param
Chuancysun Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion mlu_op_test.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,8 @@ enum OpType {
DYNAMIC_POINT_TO_VOXEL_BACKWARD = 404;
DYNAMIC_POINT_TO_VOXEL_FORWARD = 405;
EXPAND = 5;
FFT = 65536;
FFT = 65536;
SGETRF2 = 65537;
Copy link
Collaborator

@shunshen93 shunshen93 Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XGETRF

FILL = 13199;
FOCAL_LOSS_SIGMOID_BACKWARD = 12322;
FOCAL_LOSS_SIGMOID_FORWARD = 15000;
Expand Down Expand Up @@ -426,6 +427,7 @@ message Node {
optional OpTensorParam op_tensor_param = 101; // OpTensorParam
optional BatchMatMulBCastParam batch_matmul_bcast_param = 132; // param
optional FFTParam fft_param = 65536; // param
optional Sgetrf2Param sgetrf2_param = 65537 ;//param
optional DCNParam dcn_param = 405;
optional LogcumsumexpParam logcumsumexp_param = 19980423;
optional LgammaParam lgamma_param = 202435;
Expand Down Expand Up @@ -1119,6 +1121,11 @@ message FFTParam {
optional float scale_factor = 4 [default = 1.0];
}

// param to call Sgetrf2()
message Sgetrf2Param {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgetrf2改成lu吧

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgetrf2改成xgetrf，不是LU

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

optional int32 mode =1 [default = 1];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少inplace的参数

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不支持inplace

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Reference-LAPACK/lapack/blob/master/SRC/dgetrf2.f#L69
getrf这个算子，应该是支持原位修改输入的

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个我们在最初时是做的原位的，但后来对接时需求更改为了非原位的

}

// param to call mluOpRoiPoolingForward()
message RoiPoolingForwardParam {
optional float spatial_scale = 1 [default = 1];
Expand Down
Loading