Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included greetings bot #42

Conversation

gibrankasif
Copy link
Contributor

@gibrankasif gibrankasif commented Oct 8, 2021

Contributes to # (add issue number here. i.e. #302)

What did you do?

Recreated the bot based on the provided example.

Why did you do it?

How have you tested it?

Yes, via the actions menu, the result was successfully run.

Were docs updated if needed?

  • No
  • Yes
  • N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

Signed-off-by: gibrankasif <[email protected]>
Copy link
Collaborator

@sforsyth089 sforsyth089 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello and thank you for this work! Can you please make this edit: change 'Someone will review it ASAP.' to 'A member of the Open Sentencing team will review when we have a chance and will let you know if we have thoughts or feedback'.

Once you make that edit let me know. The rest looks great.

@demilolu
Copy link
Contributor

@gibrankasif have you been able to make the changes @sforsyth089 mentioned?

@demilolu demilolu merged commit f193a10 into Call-for-Code-for-Racial-Justice:main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants