Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #4

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

lil5
Copy link

@lil5 lil5 commented Jul 6, 2021

  • Updated dependencies
  • Fixed an issue where if there were no meta aria it would use the previous meta
  • Removed npm package assert there is no need to use this if node already has one built in
  • Move to new mocha mocharc.yaml file, I have copied over the previous configurations)
  • Rename test markdown files to case1.md from 0.0.1.md

Tests run ✔️

@@ -20,6 +20,7 @@ function meta(md, state, start, end, silent) {
return false
}
if (!get(state, start).match(/^---$/)) {
md.meta = {}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed #5

Copy link

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟

@kkirik
Copy link

kkirik commented Nov 2, 2023

@AugustinMauroy Can you merge this PR?

@AugustinMauroy
Copy link

I'm not the maintainer of this package

@kkirik
Copy link

kkirik commented Nov 2, 2023

I'm not the maintainer of this package

Sorry, You reviewed this PR and I thought that you're a maintainer

@kkirik
Copy link

kkirik commented Nov 2, 2023

@AugustinMauroy Can you merge this PR?

cc @scott-wyatt
Can you help me with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants