Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calamari-predict-and-eval args #366

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Oct 9, 2024

This adds the --voter args (available in calamari-predict) to calamari-predict-and-eval.

Moreover, it fixes --output_individual_voters (relevant in combination with --dump): this assumed that voters are implemented as ensemble models, which they are not (anymore?). Now one needs to look up the individual predictor outputs in the PredictionResult lists contained in the second half of the Sample.outputs tuple.

Also contains a fix for ids contained in the --dump pickle: if serializing as a set, the order gets lost and thus useless.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@f0139d6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
calamari_ocr/scripts/predict_and_eval.py 0.00% 3 Missing ⚠️
calamari_ocr/ocr/evaluator.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##             master    #366   +/-   ##
========================================
  Coverage          ?   0.00%           
========================================
  Files             ?     129           
  Lines             ?    6862           
  Branches          ?       0           
========================================
  Hits              ?       0           
  Misses            ?    6862           
  Partials          ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants