Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Basic Spinner #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Basic Spinner #125

wants to merge 1 commit into from

Conversation

Sumukh
Copy link
Member

@Sumukh Sumukh commented Mar 18, 2017

There's a noticeable delay when using oh.cs61a.org before the page renders - this is a temporary attempt at a loading page

it looks like this:
spinner

I'm open to using any of the spinners here: http://tobiasahlin.com/spinkit/

@Sumukh
Copy link
Member Author

Sumukh commented Mar 18, 2017

Another approach I'd be okay with is just using the offline indicator (maybe changing the copy or color)

Copy link
Member

@knrafto knrafto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you deploy to staging? I have a feeling it won't be shown for that long (I.e. I think most of the loading time is HTML/JS)

@@ -26,6 +26,58 @@ a:hover {
text-decoration:none;
}

/* Loading Spinner */
.spinner {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

@Sumukh
Copy link
Member Author

Sumukh commented Mar 18, 2017

It's up: http://officehours-web-staging.app.cs61a.org/

it is not up for very long - but there is movement. I think something that might be better would just displaying the OH favicon center aligned.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants