Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported python versions #883

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Update supported python versions #883

merged 6 commits into from
Nov 27, 2024

Conversation

tpazderka
Copy link
Collaborator

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.
  • New code is annotated.
  • Changes are covered by tests.

3.8 has reached EOL, added new versions.

@tpazderka
Copy link
Collaborator Author

tpazderka commented Oct 18, 2024

@schlenk It looks like pylama is not up to speed with development.

No action since January: klen/pylama#249

I would argue to drop it in favor of ruff (and switch to it as a formatter as well to get rid of duality of tools).

@schlenk
Copy link
Collaborator

schlenk commented Oct 18, 2024

Agreed on switching to ruff, it seems to be the better choice currently.

src/oic/oauth2/base.py Dismissed Show dismissed Hide dismissed
src/oic/utils/sdb.py Dismissed Show dismissed Hide dismissed
@tpazderka tpazderka requested a review from schlenk November 19, 2024 12:28
Copy link
Collaborator

@schlenk schlenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


from exceptions import AttributeError, Exception, IndexError, KeyboardInterrupt, KeyError, OSError
from mako.lookup import TemplateLookup
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a little surprising from a isort/pep8 styleguide perspective.
mako.lookup should be third party and not lined up with the stdlib stuff.

But if ruff thinks its the way, I'm fine with it.

@tpazderka tpazderka merged commit 0bd1ead into master Nov 27, 2024
10 checks passed
@tpazderka tpazderka deleted the python-support branch November 27, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants