Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging without format string #871

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Fix logging without format string #871

merged 3 commits into from
Feb 28, 2024

Conversation

schlenk
Copy link
Collaborator

@schlenk schlenk commented Feb 27, 2024

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.
  • New code is annotated.
  • Changes are covered by tests.

When trying to hook opentelemetry up to the code, it blows up trying to consume log messages without a format string.

@schlenk schlenk marked this pull request as ready for review February 28, 2024 13:17
@schlenk schlenk requested a review from tpazderka February 28, 2024 13:18
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 63.80%. Comparing base (37024ad) to head (10364b5).

Files Patch % Lines
src/oic/oic/provider.py 50.00% 3 Missing ⚠️
src/oic/oauth2/base.py 0.00% 1 Missing ⚠️
src/oic/utils/authn/saml.py 0.00% 1 Missing ⚠️
src/oic/utils/http_util.py 0.00% 1 Missing ⚠️
src/oic/utils/keyio.py 0.00% 1 Missing ⚠️
src/oic/utils/rp/__init__.py 0.00% 1 Missing ⚠️
src/oic/utils/rp/oauth2.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #871   +/-   ##
=======================================
  Coverage   63.80%   63.80%           
=======================================
  Files          64       64           
  Lines       11879    11879           
  Branches     2155     2155           
=======================================
  Hits         7579     7579           
  Misses       3697     3697           
  Partials      603      603           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlenk schlenk merged commit 346f950 into master Feb 28, 2024
9 checks passed
@schlenk schlenk deleted the fix_logging branch February 28, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants