Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"code_challenge_methods_supported" added (https://datatracker.ietf.org/doc/html/rfc8414#section-2) #815

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ The format is based on the [KeepAChangeLog] project.

## 1.4.0 [2022-05-23]

### Added
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.4.0 is released, open a new section above for the next version please.

- [#815] New Provider Configuration `code_challenge_methods_supported` added

### Changed
- [#810] Drop python 3.6 support

Expand All @@ -17,6 +20,7 @@ The format is based on the [KeepAChangeLog] project.

[#810]: https://github.com/OpenIDC/pyoidc/pull/810
[#812]: https://github.com/OpenIDC/pyoidc/pull/812
[#815]: https://github.com/OpenIDC/pyoidc/pull/815

## 1.3.0 [2021-07-09]

Expand Down
3 changes: 3 additions & 0 deletions src/oic/oic/message.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
from jwkest.jwe import factory as JWE_factory
from jwkest.jwt import JWT

from oic import CC_METHOD
from oic.exception import InvalidRequest
from oic.exception import IssuerMismatch
from oic.exception import MessageException
Expand Down Expand Up @@ -886,6 +887,7 @@ class ProviderConfigurationResponse(Message):
"request_object_encryption_enc_values_supported": OPTIONAL_LIST_OF_STRINGS,
"token_endpoint_auth_methods_supported": OPTIONAL_LIST_OF_STRINGS,
"token_endpoint_auth_signing_alg_values_supported": OPTIONAL_LIST_OF_STRINGS,
"code_challenge_methods_supported": REQUIRED_LIST_OF_STRINGS,
"display_values_supported": OPTIONAL_LIST_OF_STRINGS,
"claim_types_supported": OPTIONAL_LIST_OF_STRINGS,
"claims_supported": OPTIONAL_LIST_OF_STRINGS,
Expand Down Expand Up @@ -917,6 +919,7 @@ class ProviderConfigurationResponse(Message):
"frontchannel_logout_session_supported": False,
"backchannel_logout_supported": False,
"backchannel_logout_session_supported": False,
"code_challenge_methods_supported": list(CC_METHOD.keys())
}

def verify(self, **kwargs):
Expand Down