Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History #191

Merged
merged 6 commits into from
Nov 4, 2024
Merged

History #191

merged 6 commits into from
Nov 4, 2024

Conversation

wr1159
Copy link

@wr1159 wr1159 commented Nov 4, 2024

Add history page to get all rooms by user

  • Add new getRoomsByUser
  • Fetch each questions based on rooms (not efficient)
  • New React components
image

@wr1159 wr1159 changed the title Feature/collab/get rooms History Nov 4, 2024
@wr1159 wr1159 self-assigned this Nov 4, 2024
SelwynAng
SelwynAng approved these changes Nov 4, 2024
View reviewed changes
Copy link

@SelwynAng SelwynAng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from one small bug with the creation of room Id (same room Id is created for same users within the same minute). Pushed fix already!

@SelwynAng SelwynAng merged commit 28a5a2a into main Nov 4, 2024
2 checks passed
@SelwynAng SelwynAng deleted the feature/collab/get-rooms branch November 4, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SelwynAng SelwynAng SelwynAng approved these changes

Assignees

@wr1159 wr1159

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wr1159 @SelwynAng